This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
Refactor load content in context #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the original code, there is a way to specify which location to load the new content (it may not always be right below the link). Do you have the same feature in new code? |
… inside embedded content
|
Now able to load new content in a specified location. Also able to support embedded links within embedded content. You can view the two implementations by following the red tags at Week 1 > Things to do > Have a look at the 'module handbook'. |
|
@anaprimawaty I like what's being done here! Do you want to tidy up this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed inline JS to make code more readable and reusable
addEmbeddedLinkBarModal() in common.js appends an empty div (i.e.
<div></div>) to each embedded-link-bar, replacing the need for an empty div (i.e.<div id="embedded-week1-general></div>) in the html files.Refactoring is only applied to week1.html for demonstration. Will apply to the rest if approach is ok!
Here is a preview