Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113-T16-4] Hospitalsaurus Rex #47

Open
wants to merge 215 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 152 commits
Commits
Show all changes
215 commits
Select commit Hold shift + click to select a range
926727c
Set theme jekyll-theme-midnight
TanJunHong Oct 1, 2020
6ec09fa
Edit AboutUs
randynyl Oct 1, 2020
38c2c16
Change John Doe to my name
Oct 1, 2020
0b8d195
Edit AboutUsUs
randynyl Oct 1, 2020
773d6f4
kiathwe-AboutUs
kiathwe97 Oct 1, 2020
26639e3
Merge pull request #3 from kiathwe97/master
randynyl Oct 1, 2020
3bba9b1
Merge pull request #2 from randynyl/master
TanJunHong Oct 1, 2020
ea794c1
Merge pull request #1 from TanJunHong/master
kiathwe97 Oct 1, 2020
9a6d009
Add Yow Lim to AboutUs
ychong032 Oct 1, 2020
7cd9424
Merge pull request #4 from ychong032/yowLim-AboutUs
ychong032 Oct 1, 2020
f40639c
Add Liew You Sheng to AboutUs
GoldenCorgi Oct 3, 2020
d6b2808
Merge pull request #5 from GoldenCorgi/master
TanJunHong Oct 3, 2020
4504291
Rename project and testing files to Rex
Oct 4, 2020
c211ee6
Fix checkstyle errors
Oct 4, 2020
918868b
Merge pull request #13 from TanJunHong/master
randynyl Oct 5, 2020
16277ce
Add necessary classes and packages
Oct 6, 2020
ce74fa7
Modify necessary classes
Oct 6, 2020
b790342
Modify main class
Oct 6, 2020
b51caa2
Modify testing files to test output
Oct 6, 2020
a0e6268
Improve code quality
Oct 6, 2020
0507751
Fix checkstyle errors
Oct 6, 2020
c914bc0
Add some JUnit tests
Oct 6, 2020
bf25a03
Merge pull request #15 from TanJunHong/master
TanJunHong Oct 7, 2020
bd7c0ba
Add JUnit test to Ui
Oct 9, 2020
cb3783b
Change syntax to adhere to coding standard
Oct 9, 2020
1d0504f
Merge pull request #17 from TanJunHong/branch-JUnit
randynyl Oct 9, 2020
ce9b7d2
Merge branch 'branch-JUnit' into master
Oct 9, 2020
1b9ea65
Add more classes to Rex
Oct 10, 2020
84fd0cd
Improve code quality
Oct 10, 2020
9cca099
Merge pull request #19 from TanJunHong/branch-Week-9
ychong032 Oct 10, 2020
20d5538
Add ability to add new patients
ychong032 Oct 10, 2020
a2b71a1
Correct checkstyle errors
ychong032 Oct 10, 2020
5ceee76
Revert greeting message
ychong032 Oct 10, 2020
716847b
Merge pull request #20 from ychong032/branch-Add-Patient
TanJunHong Oct 10, 2020
a1c6733
Add retrieve function to Rex
Oct 11, 2020
7fae2d1
Modify add command
Oct 11, 2020
8610fed
Improve code quality
Oct 11, 2020
3a8be29
Move patient list related methods to PatientList class
Oct 11, 2020
4acf50e
Update JavaDocs
Oct 11, 2020
bce0713
Update testing files to reflect new features
Oct 11, 2020
8835d01
Update build.gradle to enable assertions
Oct 11, 2020
c28f206
Merge pull request #21 from TanJunHong/branch-Week-9
GoldenCorgi Oct 11, 2020
d9da09d
Merge branch 'branch-Week-9' into master
Oct 11, 2020
f73845b
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 11, 2020
baf8357
Improve user guide
Oct 11, 2020
4a06f0a
Update developer guide
Oct 11, 2020
ea120a9
Add some assertions
Oct 12, 2020
f611779
Improve assertions
Oct 12, 2020
f5d5178
Merge pull request #23 from TanJunHong/branch-Assertions
kiathwe97 Oct 12, 2020
a68c821
Merge branch 'branch-Assertions' into master
Oct 12, 2020
340b6d6
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 12, 2020
a88c338
Add basic logging
Oct 12, 2020
d3162f8
Merge pull request #25 from TanJunHong/branch-Logging
randynyl Oct 13, 2020
627d3b6
Merge branch 'branch-Logging' into master
Oct 13, 2020
2292bf5
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 13, 2020
c7ee508
Add create appointment function
randynyl Oct 13, 2020
31fda17
Add loading and storing of appointments
randynyl Oct 13, 2020
76d29b8
Add book functionality
randynyl Oct 13, 2020
c93cd0a
Merge pull request #27 from randynyl/master
TanJunHong Oct 14, 2020
56fa9bb
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 14, 2020
7e0b86d
Fix checkstyle errors
Oct 14, 2020
84ee9f5
Merge pull request #29 from TanJunHong/branch-Fixes
randynyl Oct 14, 2020
a7a9fbe
added ability to edit patient details
GoldenCorgi Oct 14, 2020
0217d8e
fixed checkstyle for editpatient functions
GoldenCorgi Oct 14, 2020
229438d
Merge pull request #30 from GoldenCorgi/master
TanJunHong Oct 14, 2020
23c4157
Merge branch 'branch-Fixes' into master
Oct 14, 2020
13a7627
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 14, 2020
5f42b57
Add delete patient capability
kiathwe97 Oct 14, 2020
e1897ca
Fixed CheckStyle issues
kiathwe97 Oct 14, 2020
b897eb3
Merge pull request #32 from kiathwe97/deletePatient
TanJunHong Oct 14, 2020
ecaa71b
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 14, 2020
fb83b42
Minor improvements to code
Oct 14, 2020
5bf78ea
Add more minor improvements
Oct 14, 2020
dd42612
Add logger
Oct 14, 2020
022587d
Update docs
Oct 14, 2020
fced104
Improve command logic
Oct 14, 2020
ba3f5eb
Improve JavaDocs
Oct 14, 2020
5dbb3ed
Update testing code
Oct 14, 2020
0849092
Merge pull request #33 from TanJunHong/branch-Fixes
GoldenCorgi Oct 14, 2020
ecfc847
Merge remote-tracking branch 'upstream/master' into master
Oct 14, 2020
dc72706
Update README.md
TanJunHong Oct 14, 2020
731c91a
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 14, 2020
be37f6a
Add list appointments under patient functionality
randynyl Oct 14, 2020
01a6b79
fix checkstyle errors
randynyl Oct 15, 2020
d33362c
Merge pull request #35 from randynyl/master
TanJunHong Oct 15, 2020
f8469d0
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp …
Oct 15, 2020
25eed3b
Add minor improvements
Oct 17, 2020
7758b74
Improve code quality
Oct 17, 2020
d820072
Add list patients function to Rex
Oct 17, 2020
808f123
Update code to pass test
Oct 17, 2020
66d8eb4
Merge pull request #42 from TanJunHong/branch-Week-10
randynyl Oct 18, 2020
25be4f6
Merge remote-tracking branch 'upstream/master' into master
Oct 18, 2020
9e0bb7a
Add initial doctor code
Oct 20, 2020
7dddd4c
Add doctor constructor
Oct 20, 2020
2357490
Improve code quality
Oct 20, 2020
3139bd3
Fix bug
Oct 20, 2020
ce9401a
Change appointments ArrayList to reside under AppointmentList
Oct 20, 2020
e83eea1
Improve code quality
Oct 20, 2020
7b5e1d9
Add DoctorList object into execute parameter
Oct 20, 2020
8517801
Improve JavaDocs
Oct 20, 2020
6c9b822
Add subtle improvements
Oct 20, 2020
cfcc52e
Add ability to load doctors
Oct 20, 2020
bbc3934
Add doctors list
Oct 20, 2020
e424154
Improve code quality
Oct 20, 2020
4a91f76
Merge branch 'master' into branch-Week-10
Oct 20, 2020
f73045a
Improve code
Oct 20, 2020
59f3328
Improve code
Oct 20, 2020
9fbea94
Update docs
Oct 20, 2020
9055e22
Merge pull request #44 from TanJunHong/branch-Week-10
randynyl Oct 20, 2020
b202c2d
edit appointments
GoldenCorgi Oct 20, 2020
eed5172
Merge pull request #45 from GoldenCorgi/master
TanJunHong Oct 20, 2020
c05fe3b
Fix checkstyle errors
Oct 20, 2020
929e8a8
Fix bugs
Oct 20, 2020
da0a216
Rename classes
Oct 20, 2020
a32964c
Update test cases
Oct 20, 2020
b8f1d1c
Remove doctors.txt
Oct 20, 2020
90ea674
Add tests and documentation
Oct 20, 2020
22a05dc
Merge branch 'master' into branch-Week-10
Oct 20, 2020
783f744
Fix checkstyle errors
Oct 20, 2020
ad8ae1e
Fix minor bugs
Oct 20, 2020
4ea4a8e
Merge pull request #47 from TanJunHong/branch-Week-10
GoldenCorgi Oct 20, 2020
59071a5
Add previously viewed list
kiathwe97 Oct 21, 2020
8566f75
Add selective display capability
kiathwe97 Oct 21, 2020
eff747a
Code refactor
kiathwe97 Oct 21, 2020
980b9a5
Merge pull request #48 from kiathwe97/displayList
TanJunHong Oct 21, 2020
8df1f66
Fix input and output tests
Oct 21, 2020
e197af8
Improve code quality
Oct 21, 2020
851433c
Add delete appointment function
Oct 21, 2020
ffe7ef6
Improve code quality and update testing
Oct 21, 2020
d6df493
Add JavaDoc
Oct 21, 2020
24ba802
Add more JUnit tests
Oct 21, 2020
ff59b08
Merge pull request #50 from TanJunHong/branch-Week-10
randynyl Oct 22, 2020
da4b70e
Update README.md
TanJunHong Oct 23, 2020
9d1ca6f
Merge branch 'branch-Week-10'
Oct 24, 2020
a1c56e3
add class diagram to DG
randynyl Oct 27, 2020
b66c3c2
Merge pull request #51 from randynyl/master
TanJunHong Oct 27, 2020
4cab89b
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp
Oct 27, 2020
89fff76
Add sequence diagram
Oct 27, 2020
2b8d761
Add to user guide
Oct 27, 2020
0b3c534
Amend typos and complete description for editappt
ychong032 Oct 27, 2020
eab233a
Merge branch 'master' into master
ychong032 Oct 27, 2020
c020318
Handle input errors and null pointer errors
ychong032 Oct 27, 2020
9cf70d2
Merge pull request #52 from TanJunHong/master
ychong032 Oct 27, 2020
fbf8515
Add throws exception to Ui test class
ychong032 Oct 27, 2020
f8a6c99
Update expected output in test classes
ychong032 Oct 27, 2020
b945273
Update I/O redirection test expected output
ychong032 Oct 27, 2020
a930909
Add new sequence diagram and edit developer guide.
ychong032 Oct 27, 2020
a6432d6
add book command SD
randynyl Oct 27, 2020
88c194b
Merge pull request #58 from randynyl/master
TanJunHong Oct 28, 2020
8075b1e
Merge pull request #56 from ychong032/branch-Handle-Input-Error
TanJunHong Oct 28, 2020
36a9c7e
Merge branch 'master' into branch-Add-Command-SD
TanJunHong Oct 28, 2020
dbc2e97
Merge pull request #57 from ychong032/branch-Add-Command-SD
TanJunHong Oct 28, 2020
4c5a721
Update PPP
Oct 28, 2020
0141799
Improve JavaDoc
Oct 28, 2020
efde996
Improve docs
Oct 31, 2020
8d7c492
Add more JUnit tests
Oct 31, 2020
c818c75
Fix minor checkstyle errors
Oct 31, 2020
2cde026
Merge pull request #59 from TanJunHong/master
TanJunHong Oct 31, 2020
f93f78d
Fix bugs
Oct 31, 2020
9cff76d
Update test file
Oct 31, 2020
69d1e89
Merge pull request #72 from TanJunHong/branch-Week-12
TanJunHong Nov 1, 2020
af26c3d
Seq diagram for UML
GoldenCorgi Nov 2, 2020
4df82e6
Update DeveloperGuide.md
GoldenCorgi Nov 2, 2020
330fbed
Update DeveloperGuide.md
GoldenCorgi Nov 2, 2020
31d733a
update ppp
GoldenCorgi Nov 2, 2020
f8e5152
Merge pull request #73 from GoldenCorgi/master
TanJunHong Nov 2, 2020
8da55d0
Fix minor errors in code and UG
Nov 4, 2020
285c43f
Merge pull request #75 from TanJunHong/branch-Week-12
TanJunHong Nov 4, 2020
6d955ad
Update add and retrieve SDs following tutor comments
ychong032 Nov 4, 2020
87d5ffe
Update PPP
ychong032 Nov 4, 2020
e2f099d
Merge pull request #76 from ychong032/branch-Week-12
ychong032 Nov 4, 2020
6e28f18
Update AboutUs.md
TanJunHong Nov 6, 2020
2e429f8
Rename liewyousheng.md to goldencorgi.md
TanJunHong Nov 6, 2020
9a6bfb0
Update AboutUs.md
TanJunHong Nov 6, 2020
287dd25
Update tanjunhong.md
TanJunHong Nov 6, 2020
c331c8d
Merge branch 'branch-Week-12'
Nov 6, 2020
a13ff18
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp
Nov 6, 2020
4ac5424
Update DeveloperGuide.md
TanJunHong Nov 6, 2020
c9f69de
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp
Nov 6, 2020
cf31975
Update README.md
TanJunHong Nov 7, 2020
b36b119
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp
Nov 7, 2020
953ca94
Update AboutUs.md
TanJunHong Nov 7, 2020
c21c86b
Update AboutUs.md
TanJunHong Nov 7, 2020
3d3f0eb
Update AboutUs.md
TanJunHong Nov 7, 2020
8ddecc3
Update DeveloperGuide.md
TanJunHong Nov 7, 2020
1f88f8e
Update UserGuide.md
TanJunHong Nov 7, 2020
5ba5450
Merge remote-tracking branch 'upstream/master'
Nov 7, 2020
479cc20
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp
Nov 7, 2020
bf893cf
Update UserGuide.md
TanJunHong Nov 7, 2020
487baac
Update DeveloperGuide.md
TanJunHong Nov 7, 2020
376c9ba
Merge branch 'master' of https://github.com/AY2021S1-CS2113-T16-4/tp
Nov 7, 2020
e966355
add PPP
randynyl Nov 7, 2020
ef2a71b
Add storage junit tests
randynyl Nov 7, 2020
3954f88
Update dg, ppp
randynyl Nov 7, 2020
9a6ff1a
Add minor improvements
Nov 7, 2020
ec02bd6
Merge pull request #77 from randynyl/master
TanJunHong Nov 7, 2020
b42cefc
Merge pull request #78 from TanJunHong/master
TanJunHong Nov 7, 2020
f2f62aa
Update tanjunhong.md
TanJunHong Nov 7, 2020
96ca68a
Update goldencorgi.md
TanJunHong Nov 7, 2020
1e3750f
Update randynyl.md
TanJunHong Nov 7, 2020
1f486bb
Update ychong032.md
TanJunHong Nov 7, 2020
c993a5d
Update and rename johndoe.md to kiathwe97.md
TanJunHong Nov 7, 2020
b559980
Update DeveloperGuide.md
TanJunHong Nov 7, 2020
67811d7
Update DeveloperGuide.md
TanJunHong Nov 7, 2020
17c2b66
Update UserGuide.md
TanJunHong Nov 7, 2020
f4cc0d4
Update DeveloperGuide.md
TanJunHong Nov 7, 2020
84e40ed
Update DeveloperGuide.md
TanJunHong Nov 7, 2020
833e2b2
Update UserGuide.md
TanJunHong Nov 7, 2020
25a062d
Add CD and SD
kiathwe97 Nov 8, 2020
71bd502
Add Junit Test
kiathwe97 Nov 8, 2020
c48c1c9
Remove test
kiathwe97 Nov 8, 2020
39b40bc
Merge pull request #80 from kiathwe97/master
TanJunHong Nov 8, 2020
24a5ea7
Update DeveloperGuide.md
TanJunHong Nov 8, 2020
d51b416
Refine book command sequence diagram
randynyl Nov 8, 2020
cd55af6
Merge pull request #81 from randynyl/master
TanJunHong Nov 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ bin/

/text-ui-test/ACTUAL.txt
text-ui-test/EXPECTED-UNIX.TXT

/data/
34 changes: 19 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,28 +1,32 @@
# Duke project template
# Hospitalsaurus ReX project

This is a project template for a greenfield Java project. It's named after the Java mascot _Duke_. Given below are instructions on how to use it.
This is a Hospitalsaurus ReX project. Given below are instructions on how to use it.

## Setting up in Intellij

Prerequisites: JDK 11 (use the exact version), update Intellij to the most recent version.

1. **Configure Intellij for JDK 11**, as described [here](https://se-education.org/guides/tutorials/intellijJdk.html).
1. **Import the project _as a Gradle project_**, as described [here](https://se-education.org/guides/tutorials/intellijImportGradleProject.html).
1. **Verify the set up**: After the importing is complete, locate the `src/main/java/seedu/duke/Duke.java` file, right-click it, and choose `Run Duke.main()`. If the setup is correct, you should see something like the below:
1. **Verify the set up**: After the importing is complete, locate the `src/main/java/seedu/rex/Rex.java` file, right-click it, and choose `Run Rex.main()`. If the setup is correct, you should see something like the below:
```
> Task :compileJava
> Task :compileJava UP-TO-DATE
> Task :processResources NO-SOURCE
> Task :classes
> Task :classes UP-TO-DATE

> Task :Duke.main()
Hello from
____ _
| _ \ _ _| | _____
| | | | | | | |/ / _ \
| |_| | |_| | < __/
|____/ \__,_|_|\_\___|

What is your name?
> Task :Rex.main()
____________________________________________________________
_ _ _ _ _ _____ __ __
| | | | (_| | | | | __ \ \ \ / /
| |__| | ___ ___ _ __ _| |_ __ _| |___ __ _ _ _ _ __ _ _ ___ | |__) |___ \ V /
| __ |/ _ \/ __| '_ \| | __/ _` | / __|/ _` | | | | '__| | | / __| | _ // _ \ > <
| | | | (_) \__ | |_) | | || (_| | \__ | (_| | |_| | | | |_| \__ \ | | \ | __// . \
|_| |_|\___/|___| .__/|_|\__\__,_|_|___/\__,_|\__,_|_| \__,_|___/ |_| \_\___/_/ \_\
| |
|_|
How may i assist you?
____________________________________________________________
Enter command:
```
Type some word and press enter to let the execution proceed to the end.

Expand All @@ -39,7 +43,7 @@ Prerequisites: JDK 11 (use the exact version), update Intellij to the most recen

### JUnit tests

* A skeleton JUnit test (`src/test/java/seedu/duke/DukeTest.java`) is provided with this project template.
* A skeleton JUnit test (`src/test/java/seedu/rex/RexTest.java`) is provided with this project template.
* If you are new to JUnit, refer to the [JUnit Tutorial at se-education.org/guides](https://se-education.org/guides/tutorials/junit.html).

## Checkstyle
Expand Down
5 changes: 3 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ test {
}

application {
mainClassName = "seedu.duke.Duke"
mainClassName = "seedu.rex.Rex"
}

shadowJar {
archiveBaseName = "duke"
archiveBaseName = "rex"
archiveClassifier = null
}

Expand All @@ -43,4 +43,5 @@ checkstyle {

run{
standardInput = System.in
enableAssertions = true
}
11 changes: 6 additions & 5 deletions docs/AboutUs.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# About us


Display | Name | Github Profile | Portfolio
--------|:----:|:--------------:|:---------:
![](https://via.placeholder.com/100.png?text=Photo) | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Tan Jun Hong | [Github](https://github.com/TanJunHong) | [Portfolio](docs/team/tanjunhong.md)
![](https://via.placeholder.com/100.png?text=Photo) | Liew You Sheng | [Github](https://github.com/GoldenCorgi) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Randy Ng | [Github](https://github.com/randynyl/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Chong Yow Lim | [Github](https://github.com/ychong032) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Tan Kiat Hwe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
78 changes: 71 additions & 7 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,31 +4,95 @@

{Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}

The app was mainly inspired by [addressbook-level2](https://github.com/se-edu/addressbook-level2).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put a content page here can be easier for the reader to navigate

### Design
The App consists of a few main components.

* Ui: The UI that deals with getting user input and displaying output.
* Command: Command to be executed.
* Parser: Parse user input and make sense of it.
* Storage: Reads data from, and writes data to, the hard disk.
* Rex: The main class that initialize the app and starts running.

The rest are just objects that the app requires.

The diagram below shows the basic design.
![image info](./pictures/UML.png)

The complete class diagram is shown below.
![image info](./pictures/classDiagram.PNG)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps can ignore some unimportant details since the diagram is too large and the texts in the diagram are too small to read?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images for some command (like book command) seem to be a little bit small which is hard to read, maybe can enlarge or separate it into small parts to explain

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The words in the diagram are too small to see it. Maybe you can split it into multiple diagrams or just simplify the content of the diagram.


### Implementation
#### Retrieve Command
The flow for the retrieve command is as follows:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add a brief introduction, like the purpose or function of the command, before the SD and steps? I think there are similar problems in the following commands.

![image info](./pictures/retrieveCommandSD.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the RetrievePatientCommand object be deleted after finishing the command? I think there are similar problems in the following commands.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "break" be "opt" instead to comply with UML notation? 😄

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the activate bar of "Command: RetrievePatientCommand" should be deactivate at the line of "4 showPatient (patient)".

1. Retrieve command extracts NRIC using parser,
2. Retrieve command searches through the patients list and obtains the patient's index.
3. Patients list returns the patient.
4. Ui object prints the patient.

#### Add Command
The flow for add command is as follows:
![image_info](./pictures/addCommandSD.PNG)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "3 getPatientName()" method return anything to "command: AddPatientCommand"? If have nothing to return why it is named as "get"?

1. Add command extracts NRIC by calling its own method.
2. Add command checks patients list if NRIC already exists. Add command ends if so.
3. Add command calls Ui object to get the patient name and date of birth from user.
4. Patient list adds the new patient.
5. Add command obtains the newly added patient.
6. Ui receives the call to print the patient.
7. The updated patients list is saved by the Storage object.
Comment on lines +44 to +50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can create a series of state diagram to help you describe these steps? Some steps like step6 are not necessary to represent in the state diagram though.



#### Book Command
The flow for the book command is shown in the sequence diagram below:
![image info](./pictures/bookApptSequenceDiagram.PNG)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to adjust the position of the activation bar?
InkedSD_LI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the text size in the diagram can be larger so that readers can see the messages more easily?
word size

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this user interact with Ui instead of Ui asking for nextLine()?
Inkeduser_LI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this diagram be simplified to improve readability? I recommend Lucid Chart! 😄

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the size of the image is a little bit small and hard to read maybe can try to ajust the size. Also, there is lots of information in the diagram without text explanation, maybe it is better to provide some necessary explanation about your diagram.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The words in the diagram are too small to see them clearly. Is is possible to resize the image?


## Product scope
### Target user profile

{Describe the target user profile}
Administrative staff of hospitals who are overworked from having various responsibilities with repetitive tasks relating to doctors and patients.

### Value proposition

{Describe the value proposition: what problem does it solve?}
Aim: To facilitate the role of the administrative staff and help them automate most of the mundane tasks that they have to do. This enables the admin staff to have a one stop application to handle appointments and fees across different specialised clinics in the hospital. Administrative staff will have more time to help patients or do things that are more meaningful, such as answering queries from patients or doctors.

## User Stories

|Version| As a ... | I want to ... | So that I can ...|
|--------|----------|---------------|------------------|
|v1.0|new user|see usage instructions|refer to them when I forget how to use the application|
|v2.0|user|find a to-do item by name|locate a to-do without having to go through the entire list|
|v1.0|admin|enter patient's details and store it|refer to them whenever I require them.|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps the user stories can include the priority level for developers to plan their work

|v1.0|admin|retrieve patient's details|use them to schedule appointments.|
|v1.0|admin|remove existing patient's details|remove unnecessary information.|
|v1.0|admin|view all appointments of a patient|remind patients of their appointments.|
|v1.0|admin|book an appointment for a patient|let them see the doctor.|
|v2.0|admin|add doctor|link doctor to appointment.|
|v2.0|admin|remove existing doctor's details|remove unnecessary information.|
|v2.0|admin|list patients|view patients.|
|v2.0|admin|edit appointments|update them.|

## Non-Functional Requirements

{Give non-functional requirements}
* The program must be easy for admins to use.
* The program must store patient's information.
* The program must store doctor's information.
* The program should run on any system running Java 11.

## Glossary

* *glossary item* - Definition
* *Hospitalsarus Rex* - The name of the program

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the testing part, it may be better to have set-up instructions to follow like how to download and import your project, which IDE is recommended, or which version of java should be used

## Instructions for manual testing

{Give instructions on how to do a manual product testing e.g., how to load sample data to be used for testing}
### Initial setup

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can add some expected outcomes which may be easier to follow

1. Download the jar file and copy it into an empty directory
2. Open command prompt, and point it to that directory
3. Type in `java -jar Rex.jar` to run the file
### Deleting a patient
There must a patient in the list.
1. `delete 1` - Deletes the patient at the first index
2. `delete 0` - It should throw error and not delete a patient.
### Adding a patient
1. `add S9999999D` - Adds a patient with NRIC `S9999999D` to the list.
2. `add S9999999D` - It should not add a patient and throw error as patient already exists.
3. `add cat` - It should throw error and not add patients as it is invalid NRIC.
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Duke
# Hospitalsaurus ReX

{Give product intro here}

Expand Down
Loading