-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2113-T16-4] Hospitalsaurus Rex #47
base: master
Are you sure you want to change the base?
Changes from 152 commits
926727c
6ec09fa
38c2c16
0b8d195
773d6f4
26639e3
3bba9b1
ea794c1
9a6d009
7cd9424
f40639c
d6b2808
4504291
c211ee6
918868b
16277ce
ce74fa7
b790342
b51caa2
a0e6268
0507751
c914bc0
bf25a03
bd7c0ba
cb3783b
1d0504f
ce9b7d2
1b9ea65
84fd0cd
9cca099
20d5538
a2b71a1
5ceee76
716847b
a1c6733
7fae2d1
8610fed
3a8be29
4acf50e
bce0713
8835d01
c28f206
d9da09d
f73845b
baf8357
4a06f0a
ea120a9
f611779
f5d5178
a68c821
340b6d6
a88c338
d3162f8
627d3b6
2292bf5
c7ee508
31fda17
76d29b8
c93cd0a
56fa9bb
7e0b86d
84ee9f5
a7a9fbe
0217d8e
229438d
23c4157
13a7627
5f42b57
e1897ca
b897eb3
ecaa71b
fb83b42
5bf78ea
dd42612
022587d
fced104
ba3f5eb
5dbb3ed
0849092
ecfc847
dc72706
731c91a
be37f6a
01a6b79
d33362c
f8469d0
25eed3b
7758b74
d820072
808f123
66d8eb4
25be4f6
9e0bb7a
7dddd4c
2357490
3139bd3
ce9401a
e83eea1
7b5e1d9
8517801
6c9b822
cfcc52e
bbc3934
e424154
4a91f76
f73045a
59f3328
9fbea94
9055e22
b202c2d
eed5172
c05fe3b
929e8a8
da0a216
a32964c
b8f1d1c
90ea674
22a05dc
783f744
ad8ae1e
4ea4a8e
59071a5
8566f75
eff747a
980b9a5
8df1f66
e197af8
851433c
ffe7ef6
d6df493
24ba802
ff59b08
da4b70e
9d1ca6f
a1c56e3
b66c3c2
4cab89b
89fff76
2b8d761
0b3c534
eab233a
c020318
9cf70d2
fbf8515
f8a6c99
b945273
a930909
a6432d6
88c194b
8075b1e
36a9c7e
dbc2e97
4c5a721
0141799
efde996
8d7c492
c818c75
2cde026
f93f78d
9cff76d
69d1e89
af26c3d
4df82e6
330fbed
31d733a
f8e5152
8da55d0
285c43f
6d955ad
87d5ffe
e2f099d
6e28f18
2e429f8
9a6bfb0
287dd25
c331c8d
a13ff18
4ac5424
c9f69de
cf31975
b36b119
953ca94
c21c86b
3d3f0eb
8ddecc3
1f88f8e
5ba5450
479cc20
bf893cf
487baac
376c9ba
e966355
ef2a71b
3954f88
9a6ff1a
ec02bd6
b42cefc
f2f62aa
96ca68a
1e3750f
1f486bb
c993a5d
b559980
67811d7
17c2b66
f4cc0d4
84e40ed
833e2b2
25a062d
71bd502
c48c1c9
39b40bc
24a5ea7
d51b416
cd55af6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,5 @@ bin/ | |
|
||
/text-ui-test/ACTUAL.txt | ||
text-ui-test/EXPECTED-UNIX.TXT | ||
|
||
/data/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
# About us | ||
|
||
|
||
Display | Name | Github Profile | Portfolio | ||
--------|:----:|:--------------:|:---------: | ||
![](https://via.placeholder.com/100.png?text=Photo) | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Tan Jun Hong | [Github](https://github.com/TanJunHong) | [Portfolio](docs/team/tanjunhong.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Liew You Sheng | [Github](https://github.com/GoldenCorgi) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Randy Ng | [Github](https://github.com/randynyl/) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Chong Yow Lim | [Github](https://github.com/ychong032) | [Portfolio](docs/team/johndoe.md) | ||
![](https://via.placeholder.com/100.png?text=Photo) | Tan Kiat Hwe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,31 +4,95 @@ | |
|
||
{Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.} | ||
|
||
The app was mainly inspired by [addressbook-level2](https://github.com/se-edu/addressbook-level2). | ||
|
||
### Design | ||
The App consists of a few main components. | ||
|
||
* Ui: The UI that deals with getting user input and displaying output. | ||
* Command: Command to be executed. | ||
* Parser: Parse user input and make sense of it. | ||
* Storage: Reads data from, and writes data to, the hard disk. | ||
* Rex: The main class that initialize the app and starts running. | ||
|
||
The rest are just objects that the app requires. | ||
|
||
The diagram below shows the basic design. | ||
![image info](./pictures/UML.png) | ||
|
||
The complete class diagram is shown below. | ||
![image info](./pictures/classDiagram.PNG) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps can ignore some unimportant details since the diagram is too large and the texts in the diagram are too small to read? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The images for some command (like book command) seem to be a little bit small which is hard to read, maybe can enlarge or separate it into small parts to explain There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The words in the diagram are too small to see it. Maybe you can split it into multiple diagrams or just simplify the content of the diagram. |
||
|
||
### Implementation | ||
#### Retrieve Command | ||
The flow for the retrieve command is as follows: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe you can add a brief introduction, like the purpose or function of the command, before the SD and steps? I think there are similar problems in the following commands. |
||
![image info](./pictures/retrieveCommandSD.png) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the RetrievePatientCommand object be deleted after finishing the command? I think there are similar problems in the following commands. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should "break" be "opt" instead to comply with UML notation? 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the activate bar of "Command: RetrievePatientCommand" should be deactivate at the line of "4 showPatient (patient)". |
||
1. Retrieve command extracts NRIC using parser, | ||
2. Retrieve command searches through the patients list and obtains the patient's index. | ||
3. Patients list returns the patient. | ||
4. Ui object prints the patient. | ||
|
||
#### Add Command | ||
The flow for add command is as follows: | ||
![image_info](./pictures/addCommandSD.PNG) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the "3 getPatientName()" method return anything to "command: AddPatientCommand"? If have nothing to return why it is named as "get"? |
||
1. Add command extracts NRIC by calling its own method. | ||
2. Add command checks patients list if NRIC already exists. Add command ends if so. | ||
3. Add command calls Ui object to get the patient name and date of birth from user. | ||
4. Patient list adds the new patient. | ||
5. Add command obtains the newly added patient. | ||
6. Ui receives the call to print the patient. | ||
7. The updated patients list is saved by the Storage object. | ||
Comment on lines
+44
to
+50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe you can create a series of state diagram to help you describe these steps? Some steps like step6 are not necessary to represent in the state diagram though. |
||
|
||
|
||
#### Book Command | ||
The flow for the book command is shown in the sequence diagram below: | ||
![image info](./pictures/bookApptSequenceDiagram.PNG) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this diagram be simplified to improve readability? I recommend Lucid Chart! 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the size of the image is a little bit small and hard to read maybe can try to ajust the size. Also, there is lots of information in the diagram without text explanation, maybe it is better to provide some necessary explanation about your diagram. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The words in the diagram are too small to see them clearly. Is is possible to resize the image? |
||
|
||
## Product scope | ||
### Target user profile | ||
|
||
{Describe the target user profile} | ||
Administrative staff of hospitals who are overworked from having various responsibilities with repetitive tasks relating to doctors and patients. | ||
|
||
### Value proposition | ||
|
||
{Describe the value proposition: what problem does it solve?} | ||
Aim: To facilitate the role of the administrative staff and help them automate most of the mundane tasks that they have to do. This enables the admin staff to have a one stop application to handle appointments and fees across different specialised clinics in the hospital. Administrative staff will have more time to help patients or do things that are more meaningful, such as answering queries from patients or doctors. | ||
|
||
## User Stories | ||
|
||
|Version| As a ... | I want to ... | So that I can ...| | ||
|--------|----------|---------------|------------------| | ||
|v1.0|new user|see usage instructions|refer to them when I forget how to use the application| | ||
|v2.0|user|find a to-do item by name|locate a to-do without having to go through the entire list| | ||
|v1.0|admin|enter patient's details and store it|refer to them whenever I require them.| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. perhaps the user stories can include the priority level for developers to plan their work |
||
|v1.0|admin|retrieve patient's details|use them to schedule appointments.| | ||
|v1.0|admin|remove existing patient's details|remove unnecessary information.| | ||
|v1.0|admin|view all appointments of a patient|remind patients of their appointments.| | ||
|v1.0|admin|book an appointment for a patient|let them see the doctor.| | ||
|v2.0|admin|add doctor|link doctor to appointment.| | ||
|v2.0|admin|remove existing doctor's details|remove unnecessary information.| | ||
|v2.0|admin|list patients|view patients.| | ||
|v2.0|admin|edit appointments|update them.| | ||
|
||
## Non-Functional Requirements | ||
|
||
{Give non-functional requirements} | ||
* The program must be easy for admins to use. | ||
* The program must store patient's information. | ||
* The program must store doctor's information. | ||
* The program should run on any system running Java 11. | ||
|
||
## Glossary | ||
|
||
* *glossary item* - Definition | ||
* *Hospitalsarus Rex* - The name of the program | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Before the testing part, it may be better to have set-up instructions to follow like how to download and import your project, which IDE is recommended, or which version of java should be used |
||
## Instructions for manual testing | ||
|
||
{Give instructions on how to do a manual product testing e.g., how to load sample data to be used for testing} | ||
### Initial setup | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe can add some expected outcomes which may be easier to follow |
||
1. Download the jar file and copy it into an empty directory | ||
2. Open command prompt, and point it to that directory | ||
3. Type in `java -jar Rex.jar` to run the file | ||
### Deleting a patient | ||
There must a patient in the list. | ||
1. `delete 1` - Deletes the patient at the first index | ||
2. `delete 0` - It should throw error and not delete a patient. | ||
### Adding a patient | ||
1. `add S9999999D` - Adds a patient with NRIC `S9999999D` to the list. | ||
2. `add S9999999D` - It should not add a patient and throw error as patient already exists. | ||
3. `add cat` - It should throw error and not add patients as it is invalid NRIC. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Duke | ||
# Hospitalsaurus ReX | ||
|
||
{Give product intro here} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put a content page here can be easier for the reader to navigate