[CS2113-F11-3] TourPlanner #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-organised the classes, placed them in respective folders.
For clients, sort by Id and name, in alphabetical order. For tours, sort by TourCode and price, in ascending and alphabetical order respectively.
# Conflicts: # src/main/java/seedu/duke/Ui.java # src/main/java/seedu/duke/commands/tours/SortTourCommand.java
Add sort functionality for Clients and Tours
…cut class of Client, Tour, Flight and Package classes
# Conflicts: # src/main/java/seedu/duke/CutClientCommand.java # src/main/java/seedu/duke/Parser.java # src/main/java/seedu/duke/SortTourCommand.java # src/main/java/seedu/duke/TourList.java # src/main/java/seedu/duke/Ui.java
Add clientPackageId attribute to ClientPackage class, add and update cut class of Client, Tour, Flight and Package classes
� Conflicts: � src/main/java/seedu/duke/Parser.java � src/test/java/seedu/duke/ParserTest.java
add's exception
Add sort flights functionality
# Conflicts: # src/main/java/seedu/duke/Parser.java
irvinseet
reviewed
Oct 27, 2021
docs/DeveloperGuide.md
Outdated
Comment on lines
12
to
17
| The add feature is facilitated mainly by `Parser`, and returns an `AddCommand` object. When `AddCommand` is executed, | ||
| the values corresponding to their fields are added. | ||
|
|
||
| After receiving the command from the user by `readCommand` of `Ui`, the command is parsed by `Parser`. The `Parser` | ||
| first determines the command type by separating the command from the subsequent arguments. After determining the | ||
| command, `Parser` executes the specific methods to sense-make the arguments, in response to the specific command. |
There was a problem hiding this comment.
You want want to add a diagram here showing the interaction between UI and Parser
There was a problem hiding this comment.
Maybe can also include an over-arching software architecture diagram to show how the high-level components connect.
docs/DeveloperGuide.md
Outdated
|
|
||
| The following activity diagram summarizes the following steps. | ||
|
|
||
|  |
docs/DeveloperGuide.md
Outdated
Comment on lines
156
to
158
| * Alternative: only iterate through the ```Package``` List. | ||
| * Pros: fast querying time. | ||
| * Cons: If the client has not subscribed to a package, none of their information can be accessed, including their contact number. |
There was a problem hiding this comment.
Formatting seems abit off here. Is this "Alternative" a standalone point. If yes, you may want to remove the bullet point for the first line
docs/DeveloperGuide.md
Outdated
|
|
||
| <br> | ||
|
|
||
| ### <u>Design Considerations</u> |
There was a problem hiding this comment.
does "design consideration" belong to "Finding a particular client". If so, please under different font sizes to indicate it is a subheading
docs/DeveloperGuide.md
Outdated
Comment on lines
23
to
26
| * `add -c NAME /cn 91234567` | ||
| * `add -t JPN /n Hokkaido-A /p 1500` | ||
| * `add -f SQ-JPN /t JPN /f SG dt 20-10-2021 18:00 /df 21-10-2021 03:00` | ||
| * `add -p ID /c NAME /t JPN /f SQ-JPN` |
There was a problem hiding this comment.
Perhaps can add the English equivalents of these commands
docs/DeveloperGuide.md
Outdated
Comment on lines
33
to
35
| ``` | ||
| -t JPN /n Hokkaido-A /p 1500 --> -t <<split>> JPN /n Hokkaido-A /p 1500 --> [-t, JPN /n Hokkaido-A /p 1500] | ||
| ``` |
There was a problem hiding this comment.
For all the steps, you may want to separate and colour code the different attributes, then the splitting will be more visual and obvious to the reader.
e.g. /n Hokkaido-a (#red) /p 1500 (#blue) --> /n Hokkaido-a (#red) <> /p 1500 (#blue)
irvinseet
reviewed
Oct 27, 2021
| * ```FindClientCommand(String name)``` | ||
|
|
||
| * ```FindTourCommand(String code)``` | ||
|
|
Add list of packages when using find client
Add minor changes to DG
Javadoc comments for Ui
…into Wayne-v2.1 # Conflicts: # src/main/java/seedu/duke/Ui.java
Gigabrain new logo
Add major bugfix to addCommand
FindClient bug fix
Fix null pointer bug
Fix clientPackageCommand bug
Add bugfix to code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TourPlanner is a desktop application meant for employees of travel agencies. Its main purpose is to manage clients, flights, accommodations and trip packages data, optimized for use via a Command Line Interface (CLI). If you can type fast, this application can allow one to access relevant travel information faster than traditional GUI applications.