-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch a assert switch on #45
Closed
ivanthengwr
wants to merge
52
commits into
nus-cs2113-AY2223S1:master
from
ivanthengwr:branch-A-assertSwitchOn
Closed
Branch a assert switch on #45
ivanthengwr
wants to merge
52
commits into
nus-cs2113-AY2223S1:master
from
ivanthengwr:branch-A-assertSwitchOn
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update about me
# Conflicts: # docs/AboutUs.md
…into branch-docs # Conflicts: # docs/AboutUs.md
…into branch-docs # Conflicts: # docs/AboutUs.md
Update about me - rachel
…-AboutUs about me - ivanTheng
…g-AboutUs Update aboutUs details and Duke
Add flight add and list functionality
# Conflicts: # src/main/java/seedu/duke/Duke.java
…assenger Branch add passenger
Line is longer than 120 characters
Add flight delete functionality
Update the flow of the overall code based. Made it more OOP by further splitting classes into different packages. Likewise, integrated all team's work code to form a cohesive and modular structure that can easily made features for our future milestones and version of this project. Will be proceeding to add JUnit, more exception and assertions for both list & delete feature of the passenger side of details. Pull request will be done after to the team's repo.
Will be adding some assertions and logs.
Overall added in the feature for list and delete, also added in a few JUnit tests. To continue making the code for defensive along the way.
…eleteListFeature Add delete and list feature for the passenger details
…-ResolveCheckError Branch a resolve check error
Added in a few more exceptions to tacklet incomplete passenger input and update input.txt to test more inputs.
Added loggers for Addpassenger, DeletePassenger, ListPassenger and Parser.
…sssertionAndLogging Branch asssertion and logging
…Unit-Test Add JUnit test for PassengerList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned on the assertion to enable the assert feature