Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SE-EDU/contributing section url in README file #36

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

jyue487
Copy link

@jyue487 jyue487 commented Jul 27, 2024

Closes #34

Copy link

@hjungwoo01 hjungwoo01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Updated the URL to the correct one.

Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is still incorrect. It should be https://se-education.org/#contributing-to-se-edu, which automatically scrolls down to the Contributing to SE-EDU header.

@hjungwoo01
Copy link

The URL is still incorrect. It should be https://se-education.org/#contributing-to-se-edu, which automatically scrolls down to the Contributing to SE-EDU header.

Yeah, this is better. I overlooked that. Directing the users straight to the “Contributing to SE-EDU” header is more efficient. Thanks for pointing that out!

@baskargopinath
Copy link

agreed with @aureliony @hjungwoo01

README.md Outdated Show resolved Hide resolved
@Carlintyj
Copy link

LGTM! I have tried the link and it scrolls to the "Contributing to SE-EDU” header section.

@damithc damithc merged commit 351d006 into nus-oss:master Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update URL of SE-EDU / Contributing section in README file
7 participants