Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TWiN script #1047

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Update TWiN script #1047

merged 4 commits into from
Feb 17, 2025

Conversation

NotTheDr01ds
Copy link
Contributor

@NotTheDr01ds NotTheDr01ds commented Feb 15, 2025 •
edited
Loading

  • Retrieves previous 7 days of contributions by default
  • Checks all repos under the nushell user - Reports against the most recent (up to 30, and we currently only have 26) with updates.
  • Uses the GitHub client to authenticate if available, with fallback to a token, then username/password
  • Cleans up a lot of the URL building using more recent Nushell commands.

fdncred
fdncred approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@NotTheDr01ds
Copy link
Contributor Author

I'm going to hold off on merging this until after #1049 - That way I can see if it turns green as a result.

@NotTheDr01ds NotTheDr01ds marked this pull request as draft February 17, 2025 12:32
@NotTheDr01ds NotTheDr01ds marked this pull request as ready for review February 17, 2025 17:59
@NotTheDr01ds NotTheDr01ds merged commit a8919f9 into nushell:main Feb 17, 2025
1 check passed
@NotTheDr01ds NotTheDr01ds deleted the update-twin-script branch February 17, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdncred fdncred fdncred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotTheDr01ds @fdncred