Remove direnv hook example #1084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge after 0.104 release. |
|
There are 2 files in the direnv folder. Did we mean to only remove one of them? |
Yes, the other appears to be an example of how to do direnv type functionality in pure Nushell (without direnv). It's just not explained. That seems to be a general problem with a lot of stuff in nu_scripts, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in nushell/nushell#15452, having a direnv example in nu_scripts and one in the Cookbook is a problem in that they've rarely been in sync. Since there's documentation for this in the Cookbook, let's remove it from nu_scripts and just have one going forward.