Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib-candidate] Clean up str append/prepend a little #797

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

texastoland
Copy link
Contributor

  • Move to directory for other str contributions
  • Add simple help docs
  • Simplify type check since only 2 cases are possible

@savente93 Are these okay?

- Move to directory for other `str` contributions
- Add simple `help` docs
- Simplify type check since only 2 cases are possible
@savente93
Copy link
Contributor

Looks OK to me thought it's been a long time since I looked at nu code.

@texastoland
Copy link
Contributor Author

Cool! The dataframe stuff is still really active if you come back 🚀

@fdncred
Copy link
Collaborator

fdncred commented Mar 20, 2024

I'm ok with this. Thanks.

@fdncred fdncred merged commit 707cda3 into nushell:main Mar 20, 2024
1 check passed
@texastoland texastoland changed the title Clean up str append/prepend a little [stdlib-candidate] Clean up str append/prepend a little Mar 20, 2024
@texastoland texastoland changed the title [stdlib-candidate] Clean up str append/prepend a little [stdlib-candidate] Clean up str append/prepend a little Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants