Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catppuccin macchiato theme #935

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add catppuccin macchiato theme #935

merged 1 commit into from
Aug 19, 2024

Conversation

A1c0
Copy link
Contributor

@A1c0 A1c0 commented Aug 19, 2024

No description provided.

@sholderbach
Copy link
Member

The test fail here seems to be the thing that was fixed in #936

If it isn't a hassle would you mind rebasing on the latest main?

Otherwise looks pretty much the same like the other catppuccin themes (minus the different colors) regarding the setup.

@sholderbach
Copy link
Member

Thanks!

@sholderbach sholderbach merged commit 7bf4491 into nushell:main Aug 19, 2024
1 check passed
@A1c0 A1c0 deleted the catppuccin-macchiato branch August 19, 2024 12:09
@fdncred
Copy link
Collaborator

fdncred commented Aug 19, 2024

The part that's missing here is the screenshot. https://github.com/nushell/nu_scripts/blob/main/themes/screenshots/README.md. I believe this is the script that creates the screenshot. https://github.com/nushell/nu_scripts/blob/main/themes/src/preview-generate-screenshots.nu

And, I believe this theme is in the wrong folder. This is a custom theme that probably belongs here https://github.com/nushell/nu_scripts/tree/main/themes/src/custom-nu-themes. It's "custom" because it's not part of the lemnos website where the other themes came from. https://github.com/lemnos/theme.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants