Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdlib-candidate Reset #986

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Stdlib-candidate Reset #986

merged 2 commits into from
Dec 5, 2024

Conversation

NotTheDr01ds
Copy link
Contributor

@NotTheDr01ds NotTheDr01ds commented Dec 4, 2024

On today's call, we decided to reset stdlib-candidate and start fresh (and try to manage it more effectively going forward).

This PR is that reset, along with an updated README for the new module.

The main thing that needs reviewing here is the README.

@fdncred
Copy link
Collaborator

fdncred commented Dec 5, 2024

LGTM. Glad you just moved the existing ones to "old". I'm wondering if there should be some more thorough instructions of how to try out stdlibcan with nupm and without nupm to make it more intuitive for people who want to dogfood with us?

@132ikl
Copy link
Contributor

132ikl commented Dec 5, 2024

I agree, we should probably add std-rfc to the "official" nupm registry

@NotTheDr01ds
Copy link
Contributor Author

I'm wondering if there should be some more thorough instructions of how to try out stdlibcan with nupm and without nupm to make it more intuitive for people who want to dogfood with us?

Agreed - Just didn't have time to write it up in this pass.

@NotTheDr01ds
Copy link
Contributor Author

I agree, we should probably add std-rfc to the "official" nupm registry

I'm still not quite sure I fully understand nupm registries, but doesn't it require that the top level nu_scripts be the registry entry? I got the feeling from another comment somewhere that it doesn't support checking out individual modules from a mono-repo.

@fdncred
Copy link
Collaborator

fdncred commented Dec 5, 2024

I haven't used nupm yet, but I don't think it requires a file be in the root of nu_scripts but one in the sub-folder like nu-hooks and themes. @kubouch or @amtoine should be able to provide more insight.

@NotTheDr01ds
Copy link
Contributor Author

I think we can add the installation instructions in a subsequent PR, right? I mean, the current version doesn't have any ;-)

That would at least get the "reset" locked in so that people can start moving things over if they want.

@fdncred
Copy link
Collaborator

fdncred commented Dec 5, 2024

That would at least get the "reset" locked in so that people can start moving things over if they want.

I guess so. People can just use <blah> to test things out, assuming they understand these will all be modules.

@fdncred fdncred merged commit 6c9f974 into nushell:main Dec 5, 2024
1 check passed
NotTheDr01ds added a commit to NotTheDr01ds/nu_scripts-fork that referenced this pull request Dec 20, 2024
On today's call, we decided to reset stdlib-candidate and start fresh
(and try to manage it more effectively going forward).

This PR is that reset, along with an updated README for the new module.

The main thing that needs reviewing here is the
[README](https://github.com/nushell/nu_scripts/pull/986/files#diff-680b95f9d9e2e9c06ee31ff6835e5d29ba11703ef7252bd42ecafa433767e0c6).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants