Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight more redirection operators #173

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

blindFS
Copy link
Contributor

@blindFS blindFS commented Dec 20, 2024

[
    "o>>"   "out>>"
    "e>>"   "err>>"
    "e+o>>" "err+out>>"
    "o+e>>" "out+err>>"
    "o>|"   "out>|"
    "e>|"   "err>|"
    "e+o>|" "err+out>|"
    "o+e>|" "out+err>|"
] @operator

Missing redirection operators added to highlights.scm.

@blindFS
Copy link
Contributor Author

blindFS commented Dec 20, 2024

Also fixed the case where the file_path in redirection is specified by a variable.

"e>>" "err>>"
"e+o>>" "err+out>>"
"o+e>>" "out+err>>"
"o>|" "out>|"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although these appear in the code, o>| / out>|, i can't get them to do anything. maybe that's a bug? i'm not sure exactly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does other options work for you?

image image

Seems to work on my computer though.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about the nushell functionality not working, not the tree-sitter-nu functionality not working.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, probably the o>| and out>| are the same as | and is not useful enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove those from the highlights.scm

@fdncred fdncred merged commit 0921525 into nushell:main Dec 20, 2024
3 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Dec 20, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants