Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of a simple plugin for nvim #57

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

aserowy
Copy link
Contributor

@aserowy aserowy commented Jan 3, 2024

Hi,

for easier integration into nvim, i added a plugin (tested with folke/lazy.nvim) to the repository. To enable automatic resolution of queries, i had to move them to queries/nu.

The plugin sets the comment string, adds filetype detection and adds the parser to treesitters parser config. If you do not want to add a program specific plugin to this repository, please let me know. Thus, i ll host a seperated one for lazy devs like me :D

Kind regards
Alexander

@aserowy
Copy link
Contributor Author

aserowy commented Jan 3, 2024

PS: The installation in lazy is dead simple: just adding { "nushell/tree-sitter-nu" }, would work.

@kubouch
Copy link

kubouch commented Jan 3, 2024

Part of me is saying that it would be better to have it in a separate repository. But since tree sitter is intended primarily for editors, maybe it makes sense to have editor integrations here as well?

@aserowy
Copy link
Contributor Author

aserowy commented Jan 3, 2024

Long term should be a direct integration into the treesitter repo imho.

I created the pr to enable easy nvim support short term.

If your goal is to not integrate I would go the seperation of concerns route and create a repo for each editor. Thus, no plugin integration conflicts with others.

@fdncred
Copy link
Collaborator

fdncred commented Jan 3, 2024

Could you also update this markdown with an example based on lazy.nvim? I think it's a great idea. I just don't know how to use :Lazy properly.

@fdncred
Copy link
Collaborator

fdncred commented Jan 3, 2024

thanks for updating the doc too. i think this makes things better.

@fdncred fdncred merged commit 23671f7 into nushell:main Jan 3, 2024
3 checks passed
aserowy added a commit to aserowy/neocode that referenced this pull request Jan 3, 2024
@fdncred
Copy link
Collaborator

fdncred commented Jan 24, 2024

FYI - This PR broke tree-sitter highlight. I'm hoping this fixes it #75

mrdgo pushed a commit to mrdgo/tree-sitter-nu that referenced this pull request Sep 23, 2024
Introduction of a simple plugin for nvim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants