-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of def using flags #74
Conversation
I see these tested def --env foo [] {}
def --env --wrapped bar [...args] {} but does it cover these? def --wrapped --env foo [] {}
def --wrapped bar [...args] {} |
I also wonder if |
@stevenxxiu I don't follow. Where is |
@fdncred There are some in the tests and some in My changes based on @kit494way, at 750dab7 if you're interested. |
if we still have |
That could make sense, but would it be better to directly change the |
@fdncred @stevenxxiu Thanks for your reviews. I will remove |
I removed |
Thanks. looks good! |
Fix parsing of def using flags
Fix #49