Removed customer-specific settings from source #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with git-checked settings.js and git-ignored ./settings.json
+ minor bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops...
I accidentally pushed straight to master, so this PR is for reference only
Feature
Introduced
settings.jswhich provides defaults for these now-removed customer-specific settings:Each setting can be overridden by a corresponding key in a customer-specific
settings.jsonin the project root (this file must be provided or compilation will fail). The file is gitignored and asettings.example.jsonis provided for reference.I also completely removed the frequent problems seeder.
Other Changes
strings.jsis nowstrings.json, because, why not.README&.env.exampleupdated