Feature/python312 #1053
Open
Feature/python312 #1053
+85
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominikandreas the objective of this PR looks similar to #1045 Can we combine both into a single PR? |
…trics_for_pr' into feature/python312
|
Sure, @whyekit-motional I've merged the changes from the PR from @michael-hoss into this one, reinstalled the requirements and ran the tests for both python 3.8 and python 3.12. Everything seems to work fine |
|
any news about this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for python 3.12 by modifying some of the requirements:
<3.6.0restriction as this version is not compatible with python 3.12<2.0.0restriction as this version is not compatible with python 3.12I ran the tests successfully with the changes and was also able to execute the jupyter notebooks without any issues. There might still be code in this repository that is not covered by either jupyter notebooks or test cases which is incompatible, but at least it's possible to install the nuscenes-devkit package via python3.12 now and use the majority of the features.