Vectorize WGSR functions to improve performance #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ernestguevarra, I've been using the zscorer package as part of a malnutrition study, and just wanted to say thanks for your work! It's been very useful.
As our dataset grows (we're currently at about 140k rows) the execution time of
addWGSR()is becoming one of the slow points in our data pipeline, so I've spent some time trying to improve the performance by vectorizinggetWGSR(). The vectorized version reduces the computation time on my computer from about 6.5 minutes to less than 1 second, at least for our particular computation.If you're interested in incorporating these changes, I'd be happy make any additional updates you suggest, or if not no problem, we can just work from our own fork. Thanks!