Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JSON-LD graph in document @context #92

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Support JSON-LD graph in document @context #92

merged 1 commit into from
Oct 31, 2023

Conversation

reinkrul
Copy link
Member

For JSON-LD documents, @context can contain a graph (object).

@reinkrul
Copy link
Member Author

See #88

woutslakhorst
woutslakhorst approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break backwards compatibility?

@reinkrul
Copy link
Member Author

This will break backwards compatibility?

Yes, but it's also (quite important?) bugfix, since now unmarshalling documents containing these will fail. So I decided changing the API was the lesser evil?

@reinkrul reinkrul merged commit 79414dd into master Oct 31, 2023
1 check passed
@reinkrul reinkrul deleted the support-context-graph branch October 31, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

@gerardsn gerardsn Awaiting requested review from gerardsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinkrul @woutslakhorst