Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validator for x509 credential attributes #3617

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

woutslakhorst
Copy link
Member

closes #3599

@woutslakhorst woutslakhorst marked this pull request as ready for review December 18, 2024 12:26
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't complete CRL checks mentioned in referenced issue

vcr/credential/validator.go Show resolved Hide resolved
vcr/credential/validator.go Show resolved Hide resolved
vcr/credential/validator.go Outdated Show resolved Hide resolved
vcr/credential/validator.go Outdated Show resolved Hide resolved
Copy link
Member

@reinkrul reinkrul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine aside from Gerard's comments

vcr/credential/validator.go Outdated Show resolved Hide resolved
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail on #3625

@woutslakhorst woutslakhorst merged commit 3e179ce into master Dec 20, 2024
9 checks passed
@woutslakhorst woutslakhorst deleted the feature/3599/x509_credential_validator branch December 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X509Credential validation
3 participants