Refactor SAN handling, add permanentIdentifier to the SAN attributes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the single `otherName` SAN type detection with a more flexible approach that supports multiple SAN types and policies. Updated the respective functions and tests to accommodate this change, ensuring backward compatibility and improved error handling.
This function searches for a matching policyType and sanTypeName in a slice of OtherNameValue structs. It returns the corresponding value if found, or an error if no match is found.
rolandgroen
changed the title
Updated `BuildSelfSignedCertChain` and `SigningCertTemplate` to accept and process a permanent identifier value. This includes modifications to test cases and utilities to validate the new permanent identifier within certificate chains.
* main: Remove unused dependencies from go.mod and go.sum Add new dependencies to go.mod and go.sum
* main: Refactor constant name SAN_TYPE_OTHER_NAME to SanTypeOtherName # Conflicts: # x509_cert/x509_utils.go # x509_cert/x509_utils_test.go
* main: Vc fields update (#8) # Conflicts: # uzi_vc_issuer/ura_issuer.go
Removed the redundant serialNumber parameter from the `uraCredential` function to streamline its usage. Adjusted the function internals accordingly to handle the credentials more effectively, ensuring the subject's DID and other name values are managed in a consolidated manner.
Bumps [github.com/alecthomas/kong](https://github.com/alecthomas/kong) from 1.2.1 to 1.3.0. - [Commits](alecthomas/kong@v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: github.com/alecthomas/kong dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/lestrrat-go/jwx/v2](https://github.com/lestrrat-go/jwx) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/lestrrat-go/jwx/releases) - [Changelog](https://github.com/lestrrat-go/jwx/blob/develop/v3/Changes) - [Commits](lestrrat-go/jwx@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: github.com/lestrrat-go/jwx/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
stevenvegt
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the single
otherNameSAN type detection with a more flexible approach that supports multiple SAN types and policies. Updated the respective functions and tests to accommodate this change, ensuring backward compatibility and improved error handling.