-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScoutEnhancer::enhanceBuilder()
improvements to be more similar to …
#2429
Merged
spawnia
merged 6 commits into
nuwave:master
from
LastDragon-ru:ScoutEnhancer-improvements
Aug 4, 2023
Merged
ScoutEnhancer::enhanceBuilder()
improvements to be more similar to …
#2429
spawnia
merged 6 commits into
nuwave:master
from
LastDragon-ru:ScoutEnhancer-improvements
Aug 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`ArgBuilderDirective`: process all `ScoutBuilderDirective` directives and directives filter support.
spawnia
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change.
Thanks, I will update PR tomorrow :) |
Seems done |
Thank you, released with https://github.com/nuwave/lighthouse/releases/tag/v6.16.0. |
Cool, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
ArgBuilderDirective
: process allScoutBuilderDirective
directives and directives filter support.Changes
Not sure why, but
ScoutEnhancer::enhanceBuilder()
use only first directivelighthouse/src/Scout/ScoutEnhancer.php
Lines 73 to 76 in 0f46c72
This is contrary to how
ArgBuilderDirective
/FieldBuilderDirective
directives works:ResolveInfo::enhanceBuilder()
process all of them. So the PR makesScoutEnhancer::enhanceBuilder()
to process allScoutBuilderDirective
directives.The PR also fix directives filter - the filter will be applied to
ScoutBuilderDirective
too.Breaking changes
If someone passes
$directiveFilter
intoResolveInfo::enhanceBuilder()
it may be need to update its declaration to accept\Nuwave\Lighthouse\Support\Contracts\ArgBuilderDirective|\Nuwave\Lighthouse\Scout\ScoutBuilderDirective
.