Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current workflow issues #2602

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix current workflow issues #2602

merged 3 commits into from
Aug 20, 2024

Conversation

k0ka
Copy link
Collaborator

@k0ka k0ka commented Aug 20, 2024

Some workflows errors out even for unchanged source code.

allow only algolia ^3, otherwise phpstan won't work

It is required for creating Laravel Scout manager. It was restricted to "^3" by something else (see previous successful run at https://github.com/nuwave/lighthouse/actions/runs/10253420278/job/28365987820)

the last items of full phpstan stack trace:

   Post the following stack trace to https://github.com/phpstan/phpstan/issues/new?template=Bug_report.yaml:
     ## /app/koka/lighthouse/vendor/laravel/scout/src/EngineManager.php(87)
     #0 /app/koka/lighthouse/vendor/laravel/scout/src/EngineManager.php(40): Laravel\Scout\EngineManager->ensureAlgoliaClientIsInstalled()
     #1 /app/koka/lighthouse/vendor/laravel/framework/src/Illuminate/Support/Manager.php(105): Laravel\Scout\EngineManager->createAlgoliaDriver()
     #2 /app/koka/lighthouse/vendor/laravel/framework/src/Illuminate/Support/Manager.php(80): Illuminate\Support\Manager->createDriver()
     #3 /app/koka/lighthouse/vendor/larastan/larastan/src/Methods/Pipes/Managers.php(33): Illuminate\Support\Manager->driver()
     #4 /app/koka/lighthouse/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Larastan\Larastan\Methods\Pipes\Managers->handle()
     #5 /app/koka/lighthouse/vendor/larastan/larastan/src/Methods/Pipes/Facades.php(68): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
     #6 /app/koka/lighthouse/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Larastan\Larastan\Methods\Pipes\Facades->handle()
     #7 /app/koka/lighthouse/vendor/larastan/larastan/src/Methods/Pipes/Contracts.php(35): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
     #8 /app/koka/lighthouse/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Larastan\Larastan\Methods\Pipes\Contracts->handle()
     #9 /app/koka/lighthouse/vendor/larastan/larastan/src/Methods/Pipes/SelfClass.php(23): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
     #10 /app/koka/lighthouse/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Larastan\Larastan\Methods\Pipes\SelfClass->handle()
     #11 /app/koka/lighthouse/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
     #12 /app/koka/lighthouse/vendor/larastan/larastan/src/Methods/Kernel.php(43): Illuminate\Pipeline\Pipeline->then()
     #13 /app/koka/lighthouse/vendor/larastan/larastan/src/Methods/Extension.php(39): Larastan\Larastan\Methods\Kernel->handle()
     #14 phar:///app/koka/lighthouse/vendor/phpstan/phpstan/phpstan.phar/src/Reflection/ClassReflection.php(512): Larastan\Larastan\Methods\Extension->hasMethod()
     #15 phar:///app/koka/lighthouse/vendor/phpstan/phpstan/phpstan.phar/src/Type/ObjectType.php(562): PHPStan\Reflection\ClassReflection->hasMethod()
     #16 phar:///app/koka/lighthouse/vendor/phpstan/phpstan/phpstan.phar/src/Type/IntersectionType.php(428): PHPStan\Type\ObjectType->hasMethod()
     #17 phar:///app/koka/lighthouse/vendor/phpstan/phpstan/phpstan.phar/src/TrinaryLogic.php(174): PHPStan\Type\IntersectionType::PHPStan\Type\{closure}()
     #18 phar:///app/koka/lighthouse/vendor/phpstan/phpstan/phpstan.phar/src/Type/IntersectionType.php(1030): PHPStan\TrinaryLogic::lazyMaxMin()
     #19 phar:///app/koka/lighthouse/vendor/phpstan/phpstan/phpstan.phar/src/Type/IntersectionType.php(429): PHPStan\Type\IntersectionType->intersectResults()

pass more responses to willReturnOnConsecutiveCalls in RedisStorageManagerTest::testDeleteSubscriber test.

Previous versions of phpunit allows empty returns values for consecutive calls. The new one requires the same number of returns as the number of calls.

@k0ka k0ka requested a review from spawnia August 20, 2024 09:46
@spawnia spawnia merged commit 0b9da72 into master Aug 20, 2024
@spawnia spawnia deleted the fix-workflows branch August 20, 2024 10:07
@spawnia
Copy link
Collaborator

spawnia commented Aug 20, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants