-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @bind
directive as a GraphQL analogue for Laravel's Route Model Binding
#2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the custom exception here as the is to catch BindExceptions and convert them to ValidationExceptions later on. These errors, however, are more of a misconfiguration error and should not be considered validation errors.
It may be personal, but it feels more Laravel-y to me.
Sorry for the many added lines, but at least most of them are coming from test cases. |
remipelhate
force-pushed
the
feature/bind-directive
branch
2 times, most recently
from
December 27, 2024 20:35
c05a733
to
2cf8ced
Compare
remipelhate
force-pushed
the
feature/bind-directive
branch
from
December 27, 2024 20:44
2cf8ced
to
23dd711
Compare
spawnia
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the concept!
Co-authored-by: Benedikt Franke <[email protected]>
spawnia
reviewed
Jan 3, 2025
…results in ModelBinding
Released with https://github.com/nuwave/lighthouse/releases/tag/v6.48.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR aims to bring (in my opinion) one of Laravel's most convenient features to Lighthouse's resolver system: Route Model Binding.
The code is based on an implementation I did a couple of months ago for a different project and as it has been really useful, I thought it maybe could be useful for others as well.
The general idea is to allow developers to define bindings for resolver arguments through the schema using a new
@bind
directive, which resolves a scalar identifier to an (Eloquent) model instance:These bindings are resolved before the query or mutation resolver is invoked, meaning that we have the instances available in the resolver without having to query for it in the resolver itself:
I added more examples and usages to the docs. Let me know if you think this would be a good addition to Lighthouse ;)
Breaking changes
This PR does not introduce any breaking changes.