Force int cast on ModelsLoader count
#2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with **legacy databases** the count for this related model returns a string like `"88"`, not `88`. ``` comments: [Comment] @hasmany(type: PAGINATOR) ``` After upgrading to PHP 8.4 this does not work anymore. And it throws a error _"Nuwave\Lighthouse\Execution\ModelsLoader\CountModelsLoader::extractCount(): Return value must be of type int, string returned"_ **Changes** Always cast to integer. Because, this count must be an integer, always. **Breaking changes** No.
spawnia
requested changes
Jan 3, 2025
Co-authored-by: Benedikt Franke <[email protected]>
|
@spawnia your suggested approach didn’t work. I also fixed the quote issue, but no luck. |
|
How is it not working? It is still casting to int. |
|
@spawnia the pipeline is failing :( it was passing at my first commit. But not after yours. |
|
I added the missing import with robsontenorio@2484c84, GitHub seems stuck at the moment. |
|
@spawnia i forced an dummy commit but I don’t get what is wrong with GitHub actions. Now phpstan complains about other things. |
|
Released with https://github.com/nuwave/lighthouse/releases/tag/v6.47.1, thank you @robsontenorio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with legacy databases the count for this related model returns a string like
"88", not88.After upgrading to PHP 8.4 this does not work anymore. And it throws a error
"Nuwave\Lighthouse\Execution\ModelsLoader\CountModelsLoader::extractCount(): Return value must be of type int, string returned"
Changes
Always cast to integer. Because, this count must be an integer, always.
Breaking changes
No.