Skip to content

fix: prioritize config preference over stored value when not 'system' #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prioritize config preference over stored value when not 'system' #323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbfadef
fix: prioritize config preference over stored value when not 'system'
abolix Sep 4, 2025
dc1002d
fix: remove trailing whitespace
abolix Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,13 @@

const knownColorSchemes = ['dark', 'light']

const preference = getStorageValue('<%= options.storage %>', '<%= options.storageKey %>') || '<%= options.preference %>'
const storedPreference = getStorageValue('<%= options.storage %>', '<%= options.storageKey %>')
const configPreference = '<%= options.preference %>'

// Use config preference if it's not 'system', otherwise use stored preference or fallback to config
const preference = configPreference !== 'system' ? configPreference : (storedPreference || configPreference)
let value = preference === 'system' ? getColorScheme() : preference

// Applied forced color mode
const forcedColorMode = de.getAttribute('data-color-mode-forced')
if (forcedColorMode) {
Expand Down
Loading