Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fixed so that head is rendered server-side. #838

Merged
merged 7 commits into from
Jul 29, 2023
Merged

feat: Fixed so that head is rendered server-side. #838

merged 7 commits into from
Jul 29, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jun 27, 2023 •
edited
Loading

🔗 Linked issue

Fixes: #868

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In Nuxt 3, if ssr: true, the head of the defineNuxtComponent is rendered server-side.
I would like to support it in Nuxt Bridge.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx changed the title feat: impl defineNuxtComponent feat: upstream defineNuxtComponent Jun 30, 2023
@wattanx wattanx changed the title feat: upstream defineNuxtComponent fix: head and useHead can be used with defineNuxtComponent Jul 22, 2023
@wattanx wattanx marked this pull request as ready for review July 22, 2023 08:45
@wattanx wattanx changed the title fix: head and useHead can be used with defineNuxtComponent fix: Fixed defineNuxtComponent head to work with SSR Jul 22, 2023
@wattanx wattanx changed the title fix: Fixed defineNuxtComponent head to work with SSR feat: Fixed defineNuxtComponent head to work with SSR Jul 22, 2023
@wattanx wattanx requested a review from danielroe July 22, 2023 09:25
@wattanx wattanx changed the title feat: Fixed defineNuxtComponent head to work with SSR feat: Fixed so that head is rendered server-side. Jul 22, 2023
@harlan-zw
Copy link
Contributor

lgtm

@danielroe danielroe merged commit 984ce7c into nuxt:main Jul 29, 2023
7 checks passed
@wattanx wattanx mentioned this pull request Aug 8, 2023
Merged
7 tasks
@danielroe danielroe mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe Awaiting requested review from danielroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

head of defineNuxtComponent is not rendered on the server side
3 participants
@wattanx @harlan-zw @danielroe