-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove nuxi
dependency and prompt to install when needed
#907
Conversation
nuxi
when needednuxi
when needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me β€οΈ
packages/bridge/src/features.ts
Outdated
return false | ||
} | ||
|
||
const { confirm } = await prompts({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly use consola.prompt
(or logger.prompt
-- not tested) to avoid new dependency
This looks another good idea but i believe safer approach might be supporting Also, do we want to keep supporting nuxi for bridge? (we might potentially drop it in next nuxi major version). |
@pi0 Do you mean that users of Bridge would have to change the cli command in their package.json scripts to |
I am suggesting adding an additional (nonconflicting) |
Sounds good to me. @wattanx are you happy (keeping all that this PR does) to also add a |
Yes, I'll add it! |
We should probably also update the docs too for the bridge migration. |
nuxi
when needednuxi
dependency and prompt to install when needed
π Linked issue
Fixes: #900
β Type of change
π Description
In nuxt/cli, nuxt is set for bin field.
This may conflict with the nuxt command in nuxt 2.
https://github.com/nuxt/cli/blob/master/package.json#L13-L17
So, I'll change to install
nuxi
when you want to use nitro.The following code was used as a reference.
https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/core/features.ts
π Checklist