-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid using shared global state for head #916
Conversation
2133b21
to
04f8ca7
Compare
unhead/vue
unhead/vue
Thanks for updating it, though in what context is this thrown?
There's probably a better fix than copying over the plugin code. |
@harlan-zw If you use I tried to think of a way to add |
unhead/vue
Hi @wattanx, sorry I couldn't get this code pushed up for your talk! I've pushed up some changes that fix the warnings being emitted which I think is the underlying issue you may have been trying to solve? For now, I think Nuxt 2 should use the deprecated plugin as the new one has some issues within Bridge. Would you mind reviewing and making sure I've understood correctly? |
No worries! Your fixes have solved the problem I was hoping to solve! |
π Linked issue
β Type of change
π Description
If you use UnheadPlugin, you need to add unhead to $options.
If useHead is used without being added, a vue warn will be thrown.
π Checklist