Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typecheck): use bunx if is running on bun #494

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(typecheck): use bunx if is running on bun #494

merged 1 commit into from
Oct 22, 2024

Conversation

HigherOrderLogic
Copy link
Contributor

🔗 Linked issue

Fix #461.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

If user is running on Bun, use bunx to install deps globally and run vue-tsc to type check.

@pi0 pi0 mentioned this pull request Oct 4, 2024
Open
1 task
@pi0
Copy link
Member

pi0 commented Oct 4, 2024

Linking to unjs/nypm#145

@HigherOrderLogic
Copy link
Contributor Author

Also, could we have a new citty release? There's quite a number of unreleased new features in the repo right now.

@pi0
Copy link
Member

pi0 commented Oct 5, 2024 •
edited
Loading

There's quite a number of unreleased new features in the repo right now.

Some are actually the reason new release is being blocked. I am sorry. please mention if there is any "bug" that needs hotfix and i can help on that. in a issue in citty repository. 🙏🏼

@HigherOrderLogic
Copy link
Contributor Author

please mention if there is any "bug"

Thanks, already did in unjs/citty#166.

danielroe
danielroe approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good!

merging - we can refactor when we implement in npym

@danielroe danielroe merged commit bb6db3f into nuxt:main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type-checking with Bun
3 participants
@HigherOrderLogic @pi0 @danielroe