ci: fix build-head size failure for forks #705
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage ? 13.33%
=======================================
Files ? 66
Lines ? 3351
Branches ? 95
=======================================
Hits ? 447
Misses ? 2873
Partials ? 31 ☔ View full report in Codecov by Sentry. |
commit: |
schirrel
changed the title
schirrel
force-pushed
the
ci/build-head-failure-for-forks
branch
from
577a44f to
fb88def
Compare
|
oops. too hasty an approval. still, thank you for looking at this |
|
THanks @danielroe , i am tring to see why the compare is failing, looks like it is relative to permisison/fork too, i am investigating that |
|
@danielroe i've tried one hour long all the things to find out why it was not working... even tho i was wondering if it is related to the fork, i saw some olders PR (weeks not that much) that the check passed. |
|
thank you! if you're happy to leave this PR open, I can experiment a bit with it |
|
@danielroe for sure, feel free to play around with it |
schirrel
force-pushed
the
ci/build-head-failure-for-forks
branch
from
1641a70 to
ec73171
Compare
|
I did some testing and looks like when changing from |
|
@danielroe sorry i wrote it wrong, by:
i mean on the yml of the main branch here https://github.com/nuxt/cli/blob/main/.github/workflows/size.yml |
|
weirdly, this still seems to be failing. |
|
@danielroe i believe is due the |
|
Brought back the repo info but continue to failing, nowi am changing to use sha as twk3 said in here twk3/rollup-size-compare-action#273 (comment) |
|
Looks like that: for pull_request it needs the ref to be |
Bundle Stats — create-nuxt-app size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — nuxi size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — nuxt-cli size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
Looking, I think the issue is not about the pull_request_target but in fact the token permissions required by the action. you can see it correctly commented above - so I'm not quite sure what is failing |
|
@danielroe that is real odd, i cant reason about it anymore : |
|
As you mentioned here #705 (comment) there was a check that passed https://github.com/nuxt/cli/actions/runs/13159970893/job/36725939692 I looked upon it and looks like the target commits are: The only difference after that commit on both repos is the merge of the dependabot bf6020b 🤔 it does not make sense |
🔗 Linked issue
Not a related issue but this state of Dan about the failure of the build-head from size for forks
#702 (comment)
❓ Type of change
📚 Description
Adding
repository: ${{ github.event.pull_request.head.repo.full_name }}to comparate build size for forked branchs tooFrom actions/checkout#551