Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: injects public environment variables in runtime #1738

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Iran-110
Copy link

@Iran-110 Iran-110 commented Mar 10, 2025

πŸ”— Linked issue

resolves #1118 and #1427

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It helps to handle runtime configs to override the options in practice.

@Iran-110 Iran-110 requested a review from danielroe as a code owner March 10, 2025 21:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.23%. Comparing base (e359c7f) to head (e975885).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/runtime/ipx.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   64.28%   64.23%   -0.06%     
==========================================
  Files          79       79              
  Lines        3699     3702       +3     
  Branches      426      426              
==========================================
  Hits         2378     2378              
- Misses       1296     1299       +3     
  Partials       25       25              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe
Copy link
Member

is there a reason why you need to use public? shouldn't NUXT_IPX_ALIAS work just as well, given that the endpoint is only called on the server side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: allow to edit image config at runtime
3 participants