Skip to content

Commit

Permalink
fix: avoid using any default config, prefer useScript defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
harlan-zw committed Apr 1, 2024
1 parent 135980a commit 6d5aba7
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion src/runtime/registry/facebook-pixel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export function useScriptFacebookPixel<T extends FacebookPixelApi>(options?: Inp
return useScript<T>({
key: 'facebook-pixel',
src: 'https://connect.facebook.net/en_US/fbevents.js',
defer: true,
}, {
...scriptOptions,
use() {
Expand Down
1 change: 0 additions & 1 deletion src/runtime/registry/fathom-analytics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export function useScriptFathomAnalytics<T extends FathomAnalyticsApi>(options?:
}
return useScript<FathomAnalyticsApi>({
src: 'https://cdn.usefathom.com/script.js',
defer: true,
...options,
}, {
...scriptOptions,
Expand Down
1 change: 0 additions & 1 deletion src/runtime/registry/hotjar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export function useScriptHotjar<T extends HotjarApi>(options?: Input<typeof Hotj
key: 'hotjar',
// requires extra steps to bundle
src: `https://static.hotjar.com/c/hotjar-${options?.id}.js?sv=${options?.sv}`,
defer: true,
}, {
...scriptOptions,
use() {
Expand Down
1 change: 0 additions & 1 deletion src/runtime/registry/intercom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export function useScriptIntercom<T extends IntercomApi>(options?: Input<typeof
return useScript<T>({
key: 'intercom',
src: `https://widget.intercom.io/widget/${options?.app_id}`,
defer: true,
}, {
...scriptOptions,
use() {
Expand Down
1 change: 0 additions & 1 deletion src/runtime/registry/segment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export function useScriptSegment<T extends SegmentApi>(options?: Input<typeof Se
'key': 'segment',
'data-global-segment-analytics-key': analyticsKey,
'src': `https://cdn.segment.com/analytics.js/v1/${options?.writeKey}/analytics.min.js`,
'defer': true,
}, {
...scriptOptions,
use() {
Expand Down

0 comments on commit 6d5aba7

Please sign in to comment.