test: e2e integration tests for ga and gtm #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
huang-julien
requested review from
harlan-zw,
flashdesignory,
kara and
housseindjirdeh
|
FWIW my dashboard is only made for testing Nuxt Scripts so blow it up all you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Following differents versions of nuxt-scripts that had issues with gtm and ga. This PR aims to add e2e tests and verify that GTM and GA are correctly sending events to google.
@flashdesignory the GTM test isn't working because
G-TESTis not available (404 when requesting the script). Anyway, we need an id for both GA and GTM 😅 i prefer to avoid always pushing events and blowing up @harlan-zw 's dashboard at each PR.