-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: improve google maps integration #191
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
β¦to feat/google-map-improvements
- $5 per 1000 loads for the Geocoding API | ||
- $2 per 1000 loads for the Static Maps API | ||
- $2 per 1000 loads for the Static Maps API - You can avoid providing a `placeholder` slot. | ||
- $5 per 1000 loads for the Geocoding API - You can avoid this by providing a `google.maps.LatLng` object instead of a string for the `center` prop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we link to the source, where the amounts are coming from?
This might get outdated as time goes by, maybe we could add a disclaimer along the lines: "The example cost is based on this source. Actual cost may change. For more accurate cost estimation, please visit ... "
π Linked issue
#103
#187
#169
#83
β Type of change
π Description
The current implementation of Google Maps has some issues, this is due to how unclear API boundaries. We need a tighter coupling around shared map and a placeholder props, everything else needs to be exposed to end users so they can implement it themselves.
Docs will still need some work in the future.
π Features
markers
prop(string | AdvancedMapMarkerOptions)[]
Customize the markers displayed on the static map and the interactive map. Fully reactive.
centerMarker
propboolean
Controls whether a marker is placed at the
center
position.options
is renamed tomapOptions
query
is renamed tocenter
, it's now recommended to use{longitude},{latitude}
rather than a text query.