feat(matomo): support custom tracker urls #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reslear is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
harlan-zw
reviewed
Sep 3, 2024
harlan-zw
reviewed
Sep 3, 2024
| @@ -4,10 +4,12 @@ import { boolean, object, optional, string } from '#nuxt-scripts-validator' | |||
| import type { RegistryScriptInput } from '#nuxt-scripts' | |||
|
|
|||
| export const MatomoAnalyticsOptions = object({ | |||
| matomoUrl: string(), // site is required | |||
| siteId: string(), | |||
| matomoUrl: optional(string()), | |||
There was a problem hiding this comment.
hm maybe we can deprecate this in favour if trackerUrl
There was a problem hiding this comment.
probably, because in the official documentation this name is used as an environment variable - apparently as syntax sugar
var u="//{$MATOMO_URL}/";
_paq.push(['setTrackerUrl', u+'matomo.php']);https://developer.matomo.org/guides/tracking-javascript-guide
I just don't know your policy on major releases so I left it for backwards compatibility. If it's not important, I'd remove it in favor of proper names and add full url's to doc.
harlan-zw
reviewed
Sep 3, 2024
harlan-zw
reviewed
Sep 3, 2024
harlan-zw
reviewed
Sep 3, 2024
harlan-zw
changed the title
|
Would you mind taking a look at the typecheck issue? then it should be good to go |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
https://docs.cookie3.co/cookie3-docs/integrations/website-integration/cookie3-script/nuxt
uses custom matomoto white-label analytics but some enhancement:
trackerUrlsiteIdbut have a questions (ps. hi @harlan-zw):
It would probably be cool to use an
orconstructionmatomoUrlortrackerUrlbut probably optional easier to implement.I didn't modify
scriptInput.srcin the hope that if it is specified to the user explicitly it will overwrite the existing one, is this true ?