Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): throw error if download fails #253

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

huang-julien
Copy link
Member

πŸ”— Linked issue

fix #233

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR stops the build process if a script download fails

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
scripts-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 7, 2024 8:41pm
scripts-playground βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 7, 2024 8:41pm

@harlan-zw harlan-zw changed the title fix: stop build process if scripts fails to be downloaded for bundle fix: throw error if download fails when bundling Sep 8, 2024
@harlan-zw harlan-zw changed the title fix: throw error if download fails when bundling fix(bundling): throw error if download fails Sep 8, 2024
@harlan-zw harlan-zw merged commit 69e6d8f into main Sep 8, 2024
4 checks passed
@harlan-zw harlan-zw deleted the fix/bundle_throw_if_fail branch September 8, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle from local npm instead of external unpkg.com to prevent connection error
2 participants