-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Textarea): resolve row count calculation errors caused by scrollbar #2040
Conversation
Hi! I'm not able to reproduce the original issue, would you mind sharing a small reproduction so I can test these changes? |
I'm sorry, this issue is indeed difficult to reproduce. Could you please follow the steps shown in the video, along with the minimal reproducible test? My computer's interface is in Traditional Chinese, but I believe the settings should be the same. 2024-09-03.6.57.31.mov
|
Thanks! I was able to reproduce it! |
Co-authored-by: Romain Hamel <[email protected]>
Co-authored-by: Romain Hamel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Thanks! π |
β¦ar (nuxt#2040) Co-authored-by: Romain Hamel <[email protected]>
β¦ar (nuxt#2040) Co-authored-by: Romain Hamel <[email protected]>
π Linked issue
N/A
β Type of change
π Description
In the current version,
<UTextarea>
does not close the scrollbar when calculating the number of rows, which causes a slight inaccuracy, resulting in an extra row being added even when there is still enough space.2024-08-14.6.51.09.mov
This PR attempts to address this by applying
overflow: hidden
before each row calculation and restoring the original setting afterward. This should help eliminate the minor inaccuracies caused by the scrollbar during the calculation process.2024-08-14.7.19.07.mov
If there are any aspects that I haven't considered thoroughly, please do let me know. I sincerely appreciate your guidance and assistance.
π Checklist