Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): button link not showing disabled classes #2189

Merged

Conversation

Tragio
Copy link
Contributor

@Tragio Tragio commented Sep 12, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Same as #2185 but for v3. Also added the respective test.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix(Button): button link not showing disabled classes v3 fix(Button): button link not showing disabled classes Sep 12, 2024
@benjamincanac benjamincanac added the v3 #1289 label Sep 12, 2024
@benjamincanac
Copy link
Member

Thanks a lot for reporting these changes on v3! 😊

@benjamincanac benjamincanac merged commit 7c2adf2 into nuxt:v3 Sep 12, 2024
1 check failed
@benjamincanac
Copy link
Member

@Tragio I think we should add the aria-disabled classes on the Link component as well: https://github.com/nuxt/ui/blob/v3/src/theme/link.ts#L11. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants