Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tailwind): use mjs template #2945

Merged
merged 2 commits into from
Dec 21, 2024
Merged

fix(tailwind): use mjs template #2945

merged 2 commits into from
Dec 21, 2024

Conversation

ineshbose
Copy link
Member

@ineshbose ineshbose commented Dec 20, 2024

πŸ”— Linked issue

resolves #2935

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Changes the TW config template to ESM syntax (I think the reason I used CJS initially was because of the require in the plugins - those may need to be changed too).

  • Let me just check on that (TODO)

Alternative would be that colors.ts is another entry point for unbuild with rollup.emitCJS as true

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ineshbose
Copy link
Member Author

Let me confirm after some testing that the PR is OK to merge! @benjamincanac

(as I mention in desc that require in ESM syntax may be another warning issue with Node 20)

@vercel vercel bot requested a deployment to Preview December 20, 2024 17:28 Abandoned
@ineshbose
Copy link
Member Author

OK - fixed from @nuxt/ui end on Node 22.

Tracking @nuxtjs/tailwindcss issue with workaround available meanwhile: nuxt-modules/tailwindcss#927 (comment) πŸ‘

@benjamincanac
Copy link
Member

Thanks @ineshbose! 😊

@benjamincanac benjamincanac merged commit 8cf9f27 into nuxt:dev Dec 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants