feat(Breadcrumb): new component

[Haythamasalama]

Enhance user experience with a breadcrumb that displays the website's hierarchical structure.

Resolves #157

[nuxt-studio]

✅ Live Preview ready!

Name	Edit	Preview	Latest Commit
ui	Edit on Studio ↗︎	View Live Preview	eec51c7

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	Nov 16, 2023 5:11pm

[Haythamasalama]

@benjamincanac It's ready to review .

I have a question about why the default button ULink can't be changed, for example, to something else like a div? In my case, if the to or href is not passed for Breadcrumb, it will default to being a button. I believe this might not be considered valid for semantic HTML?

[benjamincanac]

Maybe we could add an as prop to choose the fallback? Like we do for the Card component: https://github.com/nuxtlabs/ui/blob/dev/src/runtime/components/layout/Card.vue#L35

Not sure about this though.

[Haythamasalama]

Maybe we could add an as prop to choose the fallback? Like we do for the Card component: https://github.com/nuxtlabs/ui/blob/dev/src/runtime/components/layout/Card.vue#L35

Not sure about this though.

I think it's good, similar to headless UI. But for breadcrumb if we have tag = as and item-tag = item-as,

[benjamincanac]

I was talking about the Link component.

[Haythamasalama]

I was talking about the Link component.

Oh, Sure, I'll create a new PR to add the as prop for ULink and thoroughly test the components that utilize it with same default button similer to Card.

[Haythamasalama]

#535

[Haythamasalama]

Can we please review this, @benjamincanac? This is the third time I've attempted to resolve conflicts and update it with the latest changes that have occurred.

[benjamincanac]

I'm so sorry about the delay but issues and PRs keep coming in. I prioritize the work on bug fixes and optimizations such as #692, #648 or #509 for example. @nuxt/ui-pro is also getting closer to release. It takes a lot of time to review PRs about new components so I'll treat them once things settle down.

[Haythamasalama]

No problem at all! Prioritizing bug fixes and optimizations is important. Thanks for your time 🙏, and best of luck with the @nuxt/ui-pro release!

[benjamincanac]

Still sorry for the delay, this will still not be part of the next 2.10.0 release, but it will be part of the 2.11 for sure!