feat(Popover): add close
method in slots
#5176
Open
+34
β14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #5161
β Type of change
π Description
Adds missing
close
prop to all Popover slots.Popover uses either Reka Popover or Reka HoverCard depending on
mode
, and since HoverCard doesn't provideclose
, it will be undefined inmode="hover"
. I reflected it in documentation. Please tell if you want me to properly reflect in in the types too (probably should be done via a generic parameter inferringmode extends 'click'
or something).I did not touch tests as similar stuff in Modal is not tested, but I did check it locally in my project before commiting.
π Checklist