-
Notifications
You must be signed in to change notification settings - Fork 932
fix(components)!: consistent exposed refs #5385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@J-Michalek I ended up using |
commit: |
|
@J-Michalek I pushed another commit to consistently expose the actual html element. I feel bad for introducing yet another breaking change but it didn't make sense to have What do you think? |
|
@benjamincanac Yeah exposing the same type for input based components makes sense! |
π Linked issue
Fixes #5380, follow-up on #5358
β Type of change
π Description
This PR standardizes exposed refs across components to always expose the underlying HTML element instead of the component instance.
const inputMenu = useTemplateRef('inputMenu') - inputMenu.value.inputRef.$el // Component instance (ComboboxInput, etc.) + inputMenu.value.inputRef // HTML element (HTMLInputElement) directlyIf you were accessing component-specific methods via
inputRef.$el, update your code to useinputRefdirectly.Other changes
ref()touseTemplateRef()π Checklist