-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Stepper): new component #549
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Canac <[email protected]>
Class priority issues in some cases when ring already defined on dark mode for example (input).
Co-authored-by: Benjamin Canac <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
Still sorry for the delay, this will still not be part of the next |
Closed
8 tasks
Unfortunately I won't have time to include this in tomorrow's release against what I said above, sorry about that. I'll also have to consider #976. Thanks for your patience! |
Closing this in favor of #976. |
Any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #180
Inspirations:
Work done for the first version of this new component (based on the tabs component):
default-index
to be able to set any step as the default active.completed-icon
,active-icon
andpending-icon
to set which icon to display on each step.display-divider
to be able to hide the horizontal line.@change event
.Preview:
In the future some ideas would be:
vertical-navigation
prop to display steps on top of each other.vertical-layout
prop to display the avatar on top of the label.read-only
prop to disable any click on the component.size
prop to set the size of all elements.color
andvariant
props to change the visual style of the step.PD:
To develop this Stepper I have used the UButton and UAvatar to simplify the amount of code. I saw in other components the use of internal components are used so I though it was not a problem. Feedback is more than welcome!! :)