fix(Forms): transparent background color on validation error #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Haythamasalama
commented
Sep 29, 2023
There was a problem hiding this comment.
@benjamincanac
I added this to enable you to test cases. Once you're finished, we will remove it.
|
Closing this in favor of this solution: #719 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #719
❓ Type of change
📚 Description
When validating the form, the color for
input,select, and other elements works well and displays the correct color passed through thecolorprop. However, after validation, the color changes tored, which is normal due to theuseFormGroupcomposable.The background color for the
redcolor istransparent, so we made changes to fix that in order to get the background color that was passed by the prop.📝 Checklist