feat(Icon): switch to nuxt-icon
with dynamic
prop or app config
#862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#267
β Type of change
π Description
This PR allows to pass a
dynamic
prop to theUIcon
so it usesnuxt-icon
underneath, this can be quite useful when using dynamic class names or for icons coming from a database for example.This behaviour can be changed globally in your
app.config.ts
throughui.icons.dynamic
:There is however a little issue with this, as we're using thei-{collection}-{name}
syntax due to egoist/tailwindcss-icons, it won't work withnuxt-icon
when using collections with dashes. In other words,<UIcon name="i-simple-icons-github" dynamic />
will not work so be careful when activating dynamic icons.The issue lies in the iconifystringToIcon
function used in theloadIcon
here: https://github.com/nuxt-modules/icon/blob/main/src/runtime/Icon.vue#L91EDIT: This has been solved by nuxt/icon#116
π Checklist