Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): add missing type for dropdown #921

Closed
wants to merge 2 commits into from

Conversation

Sma11X
Copy link
Contributor

@Sma11X Sma11X commented Nov 6, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Follow #882

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
ui βœ… Ready (Inspect) Visit Preview Nov 6, 2023 1:49am

@benjamincanac
Copy link
Member

Not sure to understand, the to prop should already be there as it's extending Link.

@Sma11X
Copy link
Contributor Author

Sma11X commented Nov 7, 2023

But still have the warn here :is="!!item.to ? NuxtLink : 'button'" at Dropdown component.
Seems like it doesn't extend to prop ? Or maybe I miss some imports ?

Copy link
Member

You mean you have a TS error when using the Dropdown component?

@Sma11X
Copy link
Contributor Author

Sma11X commented Nov 7, 2023

Yes, I was trying Dropdown component at playground locally and found the error Property 'to' does not exist on type 'DropdownItem'. . I'm the only one has this error ? πŸ˜₯

Copy link
Member

Are you sure you've been passing double arrays to the items prop?

@Sma11X
Copy link
Contributor Author

Sma11X commented Nov 7, 2023

I mean I found this error at Dropdown.vue this file, it can use correctly at playground.

Copy link
Member

It is correctly typed for me, did you run pnpm run dev:prepare?
CleanShot 2023-11-07 at 11.01.38@2x.png

@Sma11X
Copy link
Contributor Author

Sma11X commented Nov 7, 2023

Yes I've tried it. Maybe it's about workspace problem and I'll figure it out. πŸ˜₯
Sorry for taking your time to review this, I'll close this PR.

@Sma11X Sma11X closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants