Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default value to variable binding #58

Merged
merged 7 commits into from
Oct 25, 2023
Merged

feat: add default value to variable binding #58

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0cdde3f
feat: add default value to variable binding
maximepvrt Oct 1, 2023
2ed60c6
update binding default value delimiter ||
maximepvrt Oct 9, 2023
66de858
Merge branch 'main' into feat/default-value-binding
farnabaz Oct 24, 2023
bd897b1
update default binding value
maximepvrt Oct 24, 2023
126d042
update docs
maximepvrt Oct 24, 2023
68516ab
Update playground/pages/index.vue
farnabaz Oct 25, 2023
5cef4ed
Update index.vue
maximepvrt Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/from-markdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,14 @@ const exit = {

// Bindings
function enterBindingContent (this: CompileContext, token: Token) {
const bindingValue = this.sliceSerialize(token).split('|');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, I prefer to use || instead of single |. This is exactly what you can use in Vue template {{ value || 'default' }}

WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farnabaz I've been using Twig syntax out of habit, but I agree that the Vue syntax is cleaner. Also, I'm not entirely sure about the proper way to define the start and end of quotes. Could you share some insights on that? Thanks!


this.enter({
type: 'textComponent',
name: 'binding',
attributes: {
value: this.sliceSerialize(token).trim()
value: bindingValue[0].trim(),
defaultValue: bindingValue.length > 1 ? bindingValue[1].trim() : null,
}
}, token)
}
Expand Down