Skip to content

fix(to-markdown): indent container contens #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Mar 4, 2025

This PR tries to fix the issues of current indent behavior by indenting all contents of a component.
The only un-indented part if the slots title and props frontmatter/code

::parent
---
foo: bar
---
  Paragraph 1

#description
  Paragraph 2

  :::child
    Paragraph 3
  :::
::

Copy link

codesandbox bot commented Mar 4, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@hendrikheil
Copy link

@farnabaz I think this is the issue I originally reported with @larbish

Let me know if we can help test this in a real world environment 👍

@farnabaz
Copy link
Collaborator Author

farnabaz commented Mar 6, 2025

@hendrikheil Indeed this fix is the result of your report 🙂

As we talked with @larbish, we moved it to the next version because this is a breaking change.
Meanwhile, we are working on a linter to achieve standard and unified formatting. Linter will also help Studio users to prevent facing automatic changes.

I'll keep this open for a while, and ping you once merged and ask for your help on testing 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants