Remove some cudf._lib.column.Column annotations in Cython #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
non-breaking
|
/ok to test |
dagardner-nv
approved these changes
Jan 16, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to rapidsai/cudf#17317,
cudf._lib.column.Columnis being phased out in favor of using pylibcudf.I found some locations where
cudf._lib.column.Columnwas used as type annotations in Cython; however, the accessed or returned objects were calling Python defined attributes/methods or used as objects in other Python objects respectively. Therefore, I don't suspect the annotations are entirely performance critical hereBy Submitting this PR I confirm: