-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate advanced Bugsee features #49
base: main
Are you sure you want to change the base?
Conversation
Future<void> bugseeSetupTest() async { | ||
testWidgets( | ||
'Test Bugsee configuration', | ||
(tester) async {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is incomplete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for this I've only prepared an integration test file for Bugsee we can later implement it
or I remove it for now ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not done, I would remove it. That way we don't have an incomplete test that could lead us to believe that Bugsee is tested even though it isn't.
Make sure you also have a Bugsee.md file under the doc folder to explain how Bugsee is integrated. |
139444c
to
934f7f6
Compare
|
||
This document provides a comprehensive guide to integrating and using **Bugsee** in your mobile application. Bugsee is a powerful tool for monitoring and debugging your app by capturing and reporting unhandled exceptions, providing insights into app crashes, user interactions, and more. | ||
|
||
## **Overview** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Headers should not be bolded. Simply use the default header format.
@@ -4,5 +4,4 @@ MINIMUM_LEVEL='debug' | |||
DAD_JOKES_BASE_URL='https://www.reddit.com/r/dadjokes' | |||
APP_STORE_URL_IOS=https://apps.apple.com/us/app/uno-calculator/id1464736591 | |||
APP_STORE_URL_Android=https://play.google.com/store/apps/details?id=uno.platform.calculator | |||
REMOTE_CONFIG_FETCH_INTERVAL_MINUTES=1 | |||
DIAGNOSTIC_ENABLED=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should DIAGNOSTIC_ENABLED=true
be removed? I also have the same comment for the prod file too.
Future<void> bugseeSetupTest() async { | ||
testWidgets( | ||
'Test Bugsee configuration', | ||
(tester) async {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not done, I would remove it. That way we don't have an incomplete test that could lead us to believe that Bugsee is tested even though it isn't.
} | ||
|
||
final class BugseeConfigState extends Equatable { | ||
/// Indicate if the app require a restart to reactivate the bugsee configurations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Indicates
- requires
- Add a period at the end.
/// cannot be true if `isBugseeEnabled == false`. | ||
final bool isVideoCaptureEnabled; | ||
|
||
/// Indicate if bugsee configuration is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you separate the sentences with a period and start sentences with a capital letter.
await registerBugseeManager(); | ||
runApp(const App()); | ||
}, | ||
GetIt.I.get<BugseeManager>().inteceptExceptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the global exception handling, I think we should send them into a more generic class that would then send them into Bugsee, but we could also dispatch to other locations, such as the application logs and potentially other monitoring SDK (such as Crashlytics). For the scope of this PR, let's just start with Bugsee and the existing logging system (that logs into the console and a log file depending on the configuration).
@@ -5,6 +5,18 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
|
|||
Prefix your items with `(Template)` if the change is about the template and not the resulting application. | |||
|
|||
## 0.22.0 | |||
- Add bugsee global inteceptor for dart exceptions to template app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, sentences should end with a period. (I know some previous notes are missing, but if we look at the initial ones, they were correct.)
GitHub Issue: #
Proposed Changes
Description
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.md
andsrc/cli/CLI.md
if you made changes to templating.AzurePipelines.md
andsrc/app/README.md
if you made changes to pipelines.Diagnostics.md
if you made changes to diagnostic tools.Architecture.md
and its diagrams if you made architecture decisions or if you introduced new recipes.doc/
folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):