Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update canary ignored packages #376

Closed
wants to merge 1 commit into from
Closed

Conversation

arianeleonard
Copy link
Contributor

@arianeleonard arianeleonard commented Nov 13, 2023

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Ignore Uno.CommunityToolkit.WinUI and Uno.WinUI.Lottie packages in canary merge to prevent canary from failing.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

Bug 293724: Fix the build stage of the UnoApplicationTemplate canary pipeline

@Soap-141
Copy link
Contributor

Soap-141 commented Nov 14, 2023

The Always applicable section should be all checked, you must go through it.

@Soap-141
Copy link
Contributor

Also, your conventional commit should probably be a fix since it's the code in the "build" folder is used by template generated applications and you fixed a part of it. The ci conventional commit should probably be used only for changes in the ".github" folder.

@arianeleonard arianeleonard changed the title ci: update canary ignored packages fix: update canary ignored packages Nov 14, 2023
@carlh98 carlh98 requested a review from a team November 14, 2023 17:33
@arianeleonard arianeleonard marked this pull request as draft November 14, 2023 18:44
@arianeleonard
Copy link
Contributor Author

PR closed, changes were made here instead : https://github.com/nventive/Canary/blob/master/version-overrides.json

@arianeleonard arianeleonard deleted the dev/arle/fix-canary branch November 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants